Giter Site home page Giter Site logo

Comments (9)

jgnagy avatar jgnagy commented on May 23, 2024

Same behavior with 2.3.3. Will try 2.4.0 shortly.

from sinja.

jgnagy avatar jgnagy commented on May 23, 2024

Same thing with 2.4.0.

from sinja.

mwpastore avatar mwpastore commented on May 23, 2024

Hi @jgnagy, thank you very much for the issue report. It looks like the Rack::Lint::InputWrapper request object doesn't respond to #size, so Sinja sees an empty and therefore invalid payload. Let me take a look at Sinja's content? helper to see if there's a better way to handle these types of inputs.

from sinja.

jgnagy avatar jgnagy commented on May 23, 2024

Ah, I see. Your demo app doesn't use rackup, instead running app.rb directly. My actual app uses several modular Sintra applications and uses rack to route the requests to them, so there is our difference.

Thank you for responding so quickly. Let me know if there is anything I can do to help, and I look forward to the fix so I can keep moving on my application.

Thanks!

from sinja.

mwpastore avatar mwpastore commented on May 23, 2024

I think that will do the trick. Add Sinja to your Gemfile (instead of gemspec) and point it at this repo. I'll release a new version of the gem that includes this fix a little later today or tomorrow. Thanks again for the report, and please feel free to reopen this issue if it's still not fixed (or open a new issue if you find anything else wrong).

from sinja.

jgnagy avatar jgnagy commented on May 23, 2024

I hate to be a pain, but I'm still getting the same results. I updated that test repo with the change (pointing directly to your master branch in the Gemfile) and I still get the send end result. Should I open a new issue?

from sinja.

mwpastore avatar mwpastore commented on May 23, 2024

You aren't being a pain at all. I missed something. I figured out a way to test it, now, so hopefully this issue won't reappear in the future. 😄 Thank you for your patience; would you please try again?

from sinja.

jgnagy avatar jgnagy commented on May 23, 2024

Looks like that fixed it in my test version (code pushed to that repo). I'll head back to my actual app and see if I have success there as well. Thanks again for the quick turnaround!

from sinja.

mwpastore avatar mwpastore commented on May 23, 2024

You're quite welcome. Sinja 1.2.4 is now available with the fix (and a number of other fixes and improvements). Thanks again for the report!

from sinja.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.