Avoid using Facades

[mybb]

Avoid using Facades

[JN-Jones]

How do we want to handle the routes.php and breadcrumbs.php files? Use the facades there? Or put $router = app('Illuminate\Path\To\Router')at the top and use $router->get(...) then?

[euantorano]

I'm happy to just use Facades in those two instances. Same with things like the bootstrap.php file.

[JN-Jones]

Good, will work through the rest then today / tomorrow

[wpillar]

Agreed.

[JN-Jones]

Can we close this? Or do we want to keep it open for future reference? Also I'm not sure how many facades are used in our packages.

[JN-Jones]

@euantorano @wpillar

[wpillar]

Have the existing instances of Facades been fixed in this repository?

[JN-Jones]

Mostly yes. Only the ConfirmationManager needs to be fixed (that class needs some love anyways) afaik.

[wpillar]

Ok, so either close this and create a new issue for ConfirmationManager or leave this one open and note somewhere what's left to do in order for this to be closed.

Personally, I would do the former.

[JN-Jones]

The ConfirmationManager needs some other things too. The main question was how we want to handle our packages: create a PR referencing this issue or simply fix them when they're noticed.

[wpillar]

Our packages are separate repositories, aren't they?

[JN-Jones]

Yeah:

• https://github.com/mybb/are-you-a-human (Not a real package, mainly a wrapper)
• https://github.com/mybb/settings
• https://github.com/mybb/auth
• https://github.com/mybb/parser

[wpillar]

Great, so they should have their own issues in their own repositories. This issue is for the mybb2 project and should be closed once the mybb2 project and the code it exclusively owns is free of Facades.