Giter Site home page Giter Site logo

Comments (2)

myoung34 avatar myoung34 commented on July 20, 2024

This actually crossed my mind a few weeks back and burnt me (spent too long debugging other things assuming my config was fine)

Thinking of putting a generic exception handler around scan_and_emit in the thread loop: tilty/cli.py#L74, having it log the errors+traces, but keep going. Alternatively, maybe the webhook emitter should do its own exception handling for the common http error cases. Also, in that case, should retryable http errors get retried or just wait for the next event loop?

This was kind of how I was thinking. If the cli/parser breaks the whole thing breaks which is fine, I think continuing but logging/dumping is how I'd go for it

Human error (bad config for a specific emitter), inconsistent network etc are all good reasons to not blow up and abort completely

If you want to start a boilerplate PR i could take over, I could start one in a few days (i have a lot of work tasks in progress right now which would delay me), or if you get one up I can merge it in. Your choice, let me know which one works best.

from tilty.

myoung34 avatar myoung34 commented on July 20, 2024

Thanks again @nalabelle 🎉

from tilty.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.