Incorrect path mapping in Framework/Extensions/Web/Slideshow.cs

[n2cms]

Incorrect path mapping in Framework/Extensions/Web/Slideshow.cs

[ahmadh21]

Hey Ben, thanks for being so prompt. Here is a sample fix I'm using temporarily. As you realized this is a problem only if using a virtual directory. Here is my suggested fix below

    public static IEnumerable<SlideshowImage> EnumerateImagesInDirectories(string relativeBasePath, string filter)
    {
        foreach (var f in N2.Utility.RecursiveListFiles(System.Web.Hosting.HostingEnvironment.MapPath(relativeBasePath.Insert(0, "~")), filter))
        {
            if (!(f.EndsWith("jpg") || f.EndsWith("gif") || f.EndsWith("png") || f.EndsWith("jpeg")))
                continue;

            yield return new SlideshowImage() {
                ImageHref = SlideshowDirectoryInclude.RemapVirtualPath(f),
                Description = null,
                Title = System.IO.Path.GetFileName(f)
            };
        }
    }

    private static string RemapVirtualPath(string physicalPath)
    {
        var appPhysicalPath = System.Web.Hosting.HostingEnvironment.ApplicationPhysicalPath.TrimEnd('/', '\\');
        var appVirtualPath = System.Web.Hosting.HostingEnvironment.ApplicationVirtualPath;
        var finalPath = physicalPath.Substring(appPhysicalPath.Length).Replace('\\', '/');

        if (appVirtualPath.Length > 1)
        {
            finalPath = appVirtualPath + finalPath;
        }

        return finalPath;
    }

I've added the tilde to relativeBasePath in MapPath to tell it to map from the executing directory, and a helper method to do the string tinkering.

Here is an image below of the path madness:

• Does not allow you to specify the "full" virtual path in your slideshow (if your virtual directory in IIS is localhost/abc and your uploads are localhost/abc/uploads you can't specify the slideshow to look under /abc/uploads as this would break). While this is OK, it is not the way the rest of N2 works. If you wanted to "standardize" this you'll have to do more string manipulation.

[bherila]

Thanks for the response! One little thing, I changed your method to this and put it in Utility.cs instead of Slideshow.cs

        /// <summary>Maps a physical path back to a virtual path, thanks to ahmadh21.</summary>
        /// <param name="physicalPath"></param>
        /// <returns></returns>
        private static string RemapVirtualPath(string physicalPath)
        {
            var appPhysicalPath = System.Web.Hosting.HostingEnvironment.ApplicationPhysicalPath.Replace('\\', '/').TrimEnd('/', '\\');
            var appVirtualPath = System.Web.Hosting.HostingEnvironment.ApplicationVirtualPath.Replace('\\', '/').TrimEnd('/', '\\');
            var finalPath = physicalPath.Substring(appPhysicalPath.Length);

            if (appVirtualPath.Length > 1)
            {
                finalPath = appVirtualPath + finalPath;
            }

            return finalPath;
        }

[bherila]

(the difference was that I put the Replace before the TrimEnd

.Replace('\\', '/').TrimEnd('/', '\\')

[bherila]

Realize, this is still not going to work if you have a virtual directory under the N2 site web root (e.g. to a remote images folder). I'm also adding an additional check to hopefully defend against that.

        /// <summary>Maps a physical path back to a virtual path, thanks to ahmadh21.</summary>
        /// <param name="physicalPath"></param>
        /// <returns></returns>
        public static string RemapVirtualPath(string physicalPath)
        {
            physicalPath = physicalPath.Replace('\\', '/').TrimEnd('/', '\\');
            var appPhysicalPath = System.Web.Hosting.HostingEnvironment.ApplicationPhysicalPath.Replace('\\', '/').TrimEnd('/', '\\');
            var appVirtualPath = System.Web.Hosting.HostingEnvironment.ApplicationVirtualPath.Replace('\\', '/').TrimEnd('/', '\\');

            if (!physicalPath.StartsWith(appPhysicalPath, StringComparison.OrdinalIgnoreCase))
                throw new ArgumentException("Physical path given must map below application physical path");

            var finalPath = physicalPath.Substring(appPhysicalPath.Length);

            if (appVirtualPath.Length > 1)
            {
                finalPath = appVirtualPath + finalPath;
            }

            return finalPath;
        }

[bherila]

And then I've also slightly modified the EnumerateImagesInDirectories

        public static IEnumerable<SlideshowImage> EnumerateImagesInDirectories(string relativeBasePath, string filter)
        {
            // sanitize input just in case
            relativeBasePath = relativeBasePath.Replace('\\', '/'); 
            filter = filter ?? "*";
            if (relativeBasePath[0] == '/')
                relativeBasePath = '~' + relativeBasePath;

            foreach (var f in N2.Utility.RecursiveListFiles(System.Web.Hosting.HostingEnvironment.MapPath(relativeBasePath), filter))
            {
                if (!(f.EndsWith("jpg") || f.EndsWith("gif") || f.EndsWith("png") || f.EndsWith("jpeg")))
                    continue;

                yield return new SlideshowImage() {
                    ImageHref = N2.Utility.RemapVirtualPath(f),
                    Description = null,
                    Title = System.IO.Path.GetFileName(f)
                };
            }
        }

[bherila]

here is a nuget build with this change if anyone feels like testing it-
https://www.dropbox.com/sh/ld58mzb1xenknrp/cp1Ln7uPEt

[bherila]

btw, this issue is also probably related #135

[ahmadh21]

That looks more robust now, great work.

[bherila]

Thanks, I also looked at stackoverflow, btw, and I could not find a better solution at the moment. I am still contemplating a Github code search to see if I can turn up anything better.