Encoding issue

[nacnudus]

Encoding issue

[nacnudus]

Thanks. I will look at this soon.

Note to self: readxl uses SET_STRING_ELT(cols[7], c, Rf_mkCharCE("text", CE_UTF8)); but when I tried this before, Encoding() still returned "unknown". I want to avoid Encoding() <- "UTF-8" because it copies potentially huge vectors/dataframes.

[nacnudus]

@stla If you have "Stéphane" in a cell, does that print correctly?

[stla]

No, there's the same issue in the cells. For example "é" and "µ" below.

> x$data$Sheet1[,"character"]
# A tibble: 8 × 1
  character
      <chr>
1         A
2         B
3        é
4      <NA>
5      <NA>
6        µ
7      <NA>
8      <NA>

[nacnudus]

Please can you test the latest version.

[stla]

Looks perfect 👍

json <- jsonlite::fromJSON("{\"a\":[\"µ\",null,2],\"é\":[\"c\",4]}", simplifyVector=FALSE)
jsoncomments <- jsonlite::fromJSON("{\"a\":[\"Stéphane\",null,null],\"é\":[null,\"bye\"]}", simplifyVector=FALSE)

library(openxlsx)

headerStyle <- createStyle(textDecoration = "Bold", border="Bottom")

wb <- createWorkbook()
addWorksheet(wb=wb, sheetName = "Sheet1")
addStyle(wb, sheet="Sheet1", style=headerStyle, rows=1, cols=seq_along(json))
for(j in seq_along(json)){
  writeData(wb, sheet="Sheet1", x=names(json)[j], startRow=1L, startCol=j)
  column <- json[[j]]
  comments <- jsoncomments[[j]]
  for(i in seq_along(column)){
    writeData(wb, sheet="Sheet1", x=column[[i]], startRow=i+1L, startCol=j)
    if(!is.null(comment <- comments[[i]])){
      writeComment(wb, sheet="Sheet1", col=j, row=i+1L, 
                   comment=createComment(comment=comment, visible=FALSE))
    }
  }
}

saveWorkbook(wb, "test001.xlsx", overwrite = TRUE) 

txl <- tidyxl::tidy_xlsx("test001.xlsx", sheets=1)

> txl$data$Sheet1[,c("character","comment")]
  character  comment
1         a     <NA>
2         é     <NA>
3         µ Stéphane
4         c     <NA>
5      <NA>      bye
6      <NA>     <NA>

[nacnudus]

Thanks!