Comments (11)
Note: Work for the merge is being done in the merge
branch. The main
and dev
branches will continue following the master
and dev
branches dis-snek
has, but will not receive updates for the near future except to keep up with any breaking changes upstream.
from molter.
Helper functions that[...]
Removing commands.
Surely removing commands should be handled by the lib itself? Not the merging-molter code?
from molter.
Also can you convert this into a checklist? So we know whats done and whats not
from molter.
Helper functions that[...]
Removing commands.Surely removing commands should be handled by the lib itself? Not the merging-molter code?
There is the issue of removing subcommands (say, if a user wanted to remove a subcommand via remove_command("foo bar")
, a problem that's somewhat unique to molter
, but... yeah, it is. Will remove.
from molter.
Also can you convert this into a checklist? So we know whats done and whats not
Soon:tm:, but of course!
from molter.
Make invoked_name way better. It's, uh, a mess right now.
Specifically what do you want changed?
from molter.
Make invoked_name way better. It's, uh, a mess right now.
Specifically what do you want changed?
I think it's easier if we look at the code behind it: https://github.com/Discord-Snake-Pit/molter/blob/f9af3325cb9a0c8c461efc4f7e93356ae92baabd/molter/overrides.py#L188-L190
...yeah, ugly, isn't it?
The problem is that invoked_name
, by technicality of subcommands dpy did this, can have whitespace and newlines, while get_first_word
intentionally removes/ignores them. So we have to make another way in order to get it.
(If we did just make it not have newlines... content_parameters
would break if so. Or at least not function correctly. Properties are proerties, so we can't really edit it.)
The current hack is a way of doing it currently, but there has to be a better way.
from molter.
Also a note: I'm thinking about splitting this into two PRs. One non-breaking change to bring the converter stuff into dis-snek
with most of molter
's functionality for BaseCommand
, and another breaking one for just message/prefix commands.
from molter.
That's only necessary if it turns out one part isn't done. Imo it's best to just pr it all at once
from molter.
Should note that the actual merge is being actively worked on in my fork of dis-snek
. There's also a thread about it on the Discord server.
from molter.
The merge is basically done and awaiting review, so it might be best to mention:
After some thinking, I think I want to just archive this repo for history's sake. I feel uncomfortable using it or the PyPI package for my own experiences due to the fact that it'll stray from the original purpose of this project.
I'm fine with either moving it back to my profile to archive it or just archiving it here.
from molter.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from molter.