Giter Site home page Giter Site logo

Comments (8)

mfn avatar mfn commented on August 20, 2024 1

I don't have time right to now to verify the issues but IMHO it's fine to close it and if I find something at a later point I would open another issue!

from sdlpop.

NagyD avatar NagyD commented on August 20, 2024

Hello and welcome!

First, I need to mention that OSX-related things were done by StaticReturn and @ecalot.
And, CMake-related things are done by @Falcury.

The Readme.txt mentions to use make -f Makefile.osx. However this file does not exist and Makefile seems to handle both cases already

You're right, the Makefiles were merged in bc3c1c1 without changing the Readme.
I updated it now: f99c423

The CMakeLists.txt actually contains a comment that the OSX configuration is missing; I was able to get i working with this change:

Okay. If possible, you should add an if so that Windows sees the original line with mingw.

Btw, what do you think about moving /docs/Readme.txt to /readme.md, format it a bit to markdown on the way?
I think it would be nicer for first time visitors to have this information here readily presented.

Markdown is a good idea, but I'm not sure whether the whole Readme belongs to the main page.
Anyway, it's a good thing if people see that this project is alive.

Thanks for your comments!
Feel free to make a pull request for anything you mentioned.

from sdlpop.

ecalot avatar ecalot commented on August 20, 2024

My mistake, I forgot to remove the -f argument in the documentation!

from sdlpop.

mfn avatar mfn commented on August 20, 2024

Ok, thanks for the feedback! :)

Btw, being a complete n00b to the whole OSX/brew thing is already shown why I don't had ogg support: it's a matter of running brew install sdl2_mixer --with-libvorbis actually.

from sdlpop.

ecalot avatar ecalot commented on August 20, 2024

I've pull requested your suggestions to the readme file

from sdlpop.

Falcury avatar Falcury commented on August 20, 2024

I added a pull request for the CMake configuration, with an if so that on Windows mingw32 and SDL2.dll will still be linked.

from sdlpop.

NagyD avatar NagyD commented on August 20, 2024

Can we close this now, or is there still something left?

from sdlpop.

NagyD avatar NagyD commented on August 20, 2024

Okay.

from sdlpop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.