Comments (7)
Hi Si,
In Nalu we have our parallel_for loops hard-wired to use Kokkos::Serial because we haven't yet verified that we are thread-safe. I know we need to do that, and will probably do it soon, but haven't yet.
I'm not sure why it can't utilize a trilinos that was built with openmp enabled. I would have thought that even if openmp is enabled, Kokkos::Serial is always available.
Alan
from nalu.
Hey @alanw0 - I agree it should always be available but its something to do with a default assumption somewhere in the code I think (i.e. that the default backend when OpenMP is enabled is != Serial). Let me know when we can start more aggressive OpenMP checking and performance work, we are on hold at the moment due to the above although trying to push MPI only ahead.
from nalu.
Should we be forcing TeamHandleType
to use Kokkos::Serial
as the execution space in KokkosInterface.h
?
typedef typename Kokkos::TeamPolicy<typename Kokkos::DefaultExecutionSpace, DynamicScheduleType>::member_type TeamHandleType;
I suspect this is picking up OpenMP
whereas the DeviceTeamPolicy
is forced to Kokkos::Serial
.
from nalu.
@sayerhs possibly so, that's worth a try, maybe @nmhamster wants to try that in his build to see if it helps.
from nalu.
@sayerhs @alanw0 - I can take a look at that and get back to you. I wanted to check if you were routinely compiling with OpenMP etc but it sounds like you are working on the parallelization etc still. Hope to get back to you with some good news shortly!
from nalu.
@nmhamster Can you please share the CMake doConfig that you are using to compile Trilinos with OpenMP flags?
from nalu.
@nmhamster @alanw0 Please see #157 and let me know if this fixes the compilation issues with Trilinos configured with OpenMP. I have tested this with Trilinos with the following options:
-DTrilinos_ENABLE_OpenMP:BOOL=ON \
-DKokkos_ENABLE_OpenMP:BOOL=ON \
from nalu.
Related Issues (20)
- Update TPLs HOT 1
- It shows that yaml-cpp/yaml.h not found during make, but I can find the yaml.h for 100% sure HOT 1
- SST and projected LOW clash
- Deprecate SuperLU HOT 3
- Six-DOF Falling 2D Sphere with overset HOT 1
- VOF (no surface tension) Prescribed Mesh Motion (elastic analogy) HOT 1
- Neo-Hookean Solid Mesh Analogy HOT 1
- OpenSSL requirement while building manually HOT 1
- Favre-averaged stress failure on forced reset at restart HOT 1
- Convert MeshDisplacementEQS to solely consolidated HOT 1
- Mac build warning HOT 3
- Hex27 in non-consolidated mode is not supported
- Questions about building Nalu under Ubuntu HOT 2
- Data probes working with overset?
- Data probe and mesh motion
- NOC on/off not fully working HOT 1
- 1.5.2 build issue HOT 4
- Portions of Non-conformal boundaries that do not overlap HOT 2
- Unexpected Error with Increasing MPI ranks related to search alg. HOT 2
- Mac build issue (Trilinos STK) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nalu.