HttpClient.DefaultRequestHeaders not applied for all Send overloads

[patagonaa]

HttpClient.DefaultRequestHeaders not applied for all Send overloads

[Ellerbach]

Is your URI a SSL one or non SSL?

The only difference between the base class and the HttpClient is on threating the SSL elements:

• https://github.com/nanoframework/System.Net.Http/blob/e65c21ff083c9bc0a164667b2e7cf0046b55335d/nanoFramework.System.Net.Http/Http/HttpMessageInvoker.cs#L52
• https://github.com/nanoframework/System.Net.Http/blob/e65c21ff083c9bc0a164667b2e7cf0046b55335d/nanoFramework.System.Net.Http/Http/HttpClient.cs#L413

[patagonaa]

Is your URI a SSL one or non SSL?

Non-SSL, but it doesn't really matter

The only difference between the base class and the HttpClient is on threating the SSL elements

I'm talking about

• https://github.com/nanoframework/System.Net.Http/blob/e65c21ff083c9bc0a164667b2e7cf0046b55335d/nanoFramework.System.Net.Http/Http/HttpMessageInvoker.cs#L52 (which is the first one you linked) vs.
• https://github.com/nanoframework/System.Net.Http/blob/e65c21ff083c9bc0a164667b2e7cf0046b55335d/nanoFramework.System.Net.Http/Http/HttpClient.cs#L364

This method sets the request used and handles the BaseAddress, DefaultRequestHeaders, etc.

When just calling HttpClient.Send(HttpRequestMessage) the base classes' method (HttpMessageInvoker.Send(HttpRequest)) is called directly and the setup regarding BaseAddress, DefaultRequestHeaders isn't done. Also, because

SendWorker(HttpRequestMessage, HttpCompletionOption) (the second method you linked) is never called either though, so Timeout, SSL, etc. is not set up either.

[Ellerbach]

OK, I see, right. Now, the key question is what's the best way to fix this?
I think a simple override of Send in the HttpClient class calling the right function with a default on HttpCompletionOption.ResponseHeadersRead.

As for the other issue, as it's community driven, super happy if you think it's a good idea to do this, then happy to review your PR :-)