e2e test and error

[narhakobyan]

e2e test and error

[NarHakobyan]

e2e test not yet integrated. I need to find free time to do that, or if you can feel free to fork and open pull-request :)

[pietrzakadrian]

I'm trying to find a problem and I think I know.

config.service.ts:

    public get(key: string): string {
        return process.env[key];
    }

You return such an object in get typeOrmConfig(): TypeOrmModuleOptions

        return {
            entities,
            migrations,
            keepConnectionAlive: true,
            type: 'postgres',
            host: this.get('POSTGRES_HOST'),
            port: this.getNumber('POSTGRES_PORT'),
            username: this.get('POSTGRES_USERNAME'),
            password: this.get('POSTGRES_PASSWORD'),
            database: this.get('POSTGRES_DATABASE'),
            dropSchema: this.nodeEnv === 'test',
            migrationsRun: true,
            logging: this.nodeEnv === 'development',
            namingStrategy: new SnakeNamingStrategy(),
        };

If I console.log this object in dev/prod mode, the values in the object match.
But when I do console.log for tests:

       [ '/Users/pietrzakadrian/Desktop/Code/production-server/src/shared/services/../../modules/**/*.entity{.ts,.js}' ],
      migrations:
       [ '/Users/pietrzakadrian/Desktop/Code/production-server/src/shared/services/../../migrations/*{.ts,.js}' ],
      keepConnectionAlive: true,
      type: 'postgres',
      host: undefined,
      port: NaN,
      username: undefined,
      password: undefined,
      database: undefined,
      synchronize: true,
      dropSchema: true,
      migrationsRun: true,
      logging: false,
      namingStrategy: SnakeNamingStrategy {} }

please correct it urgently.

[pietrzakadrian]

Could I ask you to do this as soon as you find time?
I am doing this project for my studies and e2e tests are required.

Thanks! :)

[antennaio]

There are a few improvements in this pull request #79 :)