Comments (3)
nikki-t
commented on August 30, 2024
1
@frankinspace - I think it may make sense to place the revision_date function in the GranuleCollectionBaseQuery class as the revision_date query parameter can be used for both Collection and Granule based searches but not for Services, Tools, or Variables.
If we place the function in the Query class which gets inherited by the Tool, Service, and Variable classes then we are creating a function in the parent class that can't really be used by the child classes. Does that seem right? (At least this is my understanding based off the CMR API documentation)
from python_cmr.
chuckwondo
commented on August 30, 2024
1
@frankinspace - I think it may make sense to place the
revision_datefunction in theGranuleCollectionBaseQueryclass as therevision_datequery parameter can be used for both Collection and Granule based searches but not for Services, Tools, or Variables.If we place the function in the
Queryclass which gets inherited by the Tool, Service, and Variable classes then we are creating a function in the parent class that can't really be used by the child classes. Does that seem right? (At least this is my understanding based off the CMR API documentation)
Yes, that's right.
from python_cmr.
frankinspace
commented on August 30, 2024
Thanks for confirming, yes I wasn't sure what 'level' it would apply to in the original description. Sounds like GranuleCollectionBaseQuery is appropriate
from python_cmr.
Related Issues (20)
- KeyError: 'feed' when using format other than 'json' HOT 2
- Collecting changes for release 0.11.0 HOT 3
- Generate documentation site HOT 2
- Query request headers are clobbered by token methods HOT 1
- Provide convenience method for adding a client-id header
- DayNightFlag type is not exported
- CI: poetry build cache key should include Python version
- Support searching for cloud-hosted collections HOT 1
- Support searching for available zarr stores HOT 7
- add CMR graphql functionalities HOT 3
- Discussion on release 0.12.0 HOT 2
- Feature: Check for correct WKT coordinate ordering
- Add vcrpy cassettes for revision_date unit tests HOT 2
- Support multiple-point searches in queries HOT 2
- Add method for setting parameter options HOT 15
- Support searching for collection by processing_level
- Support searching for collection and granule by platform
- Support searching by multiple platforms
- Enable STAC Output HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python_cmr.