nasa/to_lab

The Core Flight System (cFS) Telemetry Output Lab App (to_lab)

Core Flight System : Framework : App : Telemetry Output Lab

This repository contains NASA's Telemetry Output Lab (to_lab), which is a framework component of the Core Flight System.

This lab application is a non-flight utility to downlink telemetry from the cFS Bundle. It is intended to be located in the apps/to_lab subdirectory of a cFS Mission Tree. The Core Flight System is bundled at https://github.com/nasa/cFS (which includes to_lab as a submodule), which includes build and execution instructions.

to_lab is a simple telemetry downlink application that sends CCSDS telecommand packets over a UDP/IP port. The UDP port and IP address are specified in the "Enable Telemetry" command. It does not provide a full CCSDS Telecommand stack implementation.

To send telemetry to the "ground" or UDP/IP port, edit the subscription table in the platform include file: fsw/platform_inc/to_lab_sub_table.h. to_lab will subscribe to the packet IDs that are listed in this table and send the telemetry packets it receives to the UDP/IP port.

Known issues

As a lab application, extensive testing is not performed prior to release and only minimal functionality is included.

Getting Help

For best results, submit issues:questions or issues:help wanted requests at https://github.com/nasa/cFS.

Official cFS page: http://cfs.gsfc.nasa.gov

to_lab's Issues

TO_subsciption_t typo

Originated by kseywald (130 on babelfish):

It looks like "to_subsciption" ought to be "to_subscription". The typo occurs in the following locations:
apps/to_lab/fsw/platform_inc/to_lab_sub_table.h:38:static TO_subsciption_t TO_SubTable[] =
apps/to_lab/fsw/platform_inc/to_lab_sub_table.h:57: /* cFE Core subsciptions */
apps/to_lab/fsw/src/to_lab_app.c:194: for (i=0; (i < (sizeof(TO_SubTable)/sizeof(TO_subsciption_t))); i++)
apps/to_lab/fsw/src/to_lab_app.c:472: for (i=0; (i < (sizeof(TO_SubTable)/sizeof(TO_subsciption_t))); i++)
apps/to_lab/fsw/src/to_lab_msg.h:84: } TO_subsciption_t;

TO_LAB should put all global variables into a global structure

Is your feature request related to a problem? Please describe.
TO_LAB has several "bare" global variables, which are not namespace-qualified. These should all be put into a global structure, similar to the way other modules isolate their global varables.

Describe the solution you'd like
Implement a TO_LAB_Global data structure to isolate these values from the global namespace.

Additional context
Note that global variables in shared objects are by default put into a "common" section which can have weird effects on namespace clashes. This is why it is important to put them into a struct (which in this case is basically a namespace isolation mechanism).

Requester Info
Joseph Hickey, Vantage Systems Inc.

Deprecate reference to deprecated output to shell tlm pkt

Is your feature request related to a problem? Please describe.
Output to shell deprecated from framework, see nasa/cFE#645

Describe the solution you'd like
Deprecate here.

Describe alternatives you've considered
Could just remove, trying to play nicely though.

Additional context
nasa/cFE#643 may add back in telemetry depending on follow-on discussion.

Requester Info
Jacob Hageman - NASA/GSFC

Remove dependencies on deprecated SB APIs

Is your feature request related to a problem? Please describe.
SB APIs deprecated in nasa/cFE#777

Describe the solution you'd like
Update to use MSG module.

Describe alternatives you've considered
None.

Additional context
None.

Requester Info
Jacob Hageman - NASA/GSFC

Update TO_LAB to use osal_id_t typedef

Is your feature request related to a problem? Please describe.
TO_LAB is using uint32 type to hold its OSAL socket ID.

Describe the solution you'd like
Should use the osal_id_t typedef instead.

Additional context
Part of ongoing effort to update all framework code to use the typedef for OSAL IDs.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

LGTM warning - no header guard in to_lab_sub_table.h

Is your feature request related to a problem? Please describe.
Missing header guard in to_lab_sub_table.h

Describe the solution you'd like
Add header guard

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Improve consistency in application of CFE_SB_MsgIdToValue/ValueToMsgId conversions

Is your feature request related to a problem? Please describe.
A CFE_SB_MsgId_t value, like other IDs, is supposed to be a unique type/opaque value that identifies a message within the SB application context. Although it is currently implemented using an integer (uint32 specifically) application should not assume this. Instead, a set of macros and inline conversion functions (CFE_SB_MsgIdToValue and CFE_SB_ValueToMsgId) are provided for when the application needs to interpret the value as an integer for a valid purpose.

Describe the solution you'd like
Add conversions where they are currently missing

Additional context
See nasa/cFE#1945 for full info. A separate issue+PR will be submitted for each framework app.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Apply standard code style

Is your feature request related to a problem? Please describe.
Inconstant style

Describe the solution you'd like
See nasa/ci_lab#30 and nasa/ci_lab#28

Describe alternatives you've considered
N/A

Additional context
N/A

Requester Info
Jacob Hageman - NASA/GSFC

Build fails with deprecated cFE/OSAL elements removed #35

Describe the bug
Build fails on 7 undeclared errors:
Errors.txt

To Reproduce
make OMIT_DEPRECATED=true prep (requires nasa/cFE#457)

Expected behavior
Clean build

System observed on:

cFS Dev Server 2
OS: Ubuntu 18.04
Versions: mostly 6.7 (+ commit above)

Reporter Info
Jacob Hageman - NASA/GSFC

Add CodeQL analysis to workflow

Is your feature request related to a problem? Please describe.
CodeQL analysis not implemented in submodules

Describe the solution you'd like
Add so alerts are generated on pull requests to submodules

Describe alternatives you've considered
None

Additional context
CodeQL is run at the bundle (nasa/cFS) level, but link to code in submodules doesn't work.

Requester Info
Jacob Hageman - NASA/GSFC

recommended lgtm issues

Recommended lgtm issues:

to_lab_app.c

switch (CFE_SB_RcvMsg(&MsgPtr, TO_Cmd_pipe, CFE_SB_POLL))
--
257 | {
258 | case CFE_SUCCESS:
259 |  
260 | MsgId = CFE_SB_GetMsgId(MsgPtr);
261 | /* For SB return statuses that imply a message: process it. */
262 | switch (MsgId)
263 | {
264 | case TO_LAB_CMD_MID:
265 | TO_exec_local_command(MsgPtr);
266 | break;
267 |  
268 | case TO_LAB_SEND_HK_MID:
269 | TO_output_status();
270 | break;
271 |  
272 | default:
273 | CFE_EVS_SendEvent(TO_MSGID_ERR_EID,CFE_EVS_EventType_ERROR,
274 | "L%d TO: Invalid Msg ID Rcvd 0x%x",__LINE__,MsgId);
275 | break;
276 | }
277 | break;
278 | default:
279 | /* Exit command processing loop if no message received. */
280 | return;
281 | }
  | This switch statement should either handle more cases, or be rewritten as an if statement.


line 56:
Struct struct <unnamed> has 17 fields; we suggest refactoring to 15 fields or fewer - see 2 Values.
group of 15 fields here
group of 2 fields here

Requester Info
Anh Van, NASA Goddard

fails to build on Raspbian

Describe the bug
Building to_lab under Raspbian (a Debian variant for Raspberry Pi SBC's) fails due to alignment issues.

/home/pi/cFS/apps/to_lab/fsw/src/to_lab_app.c:408:25: error: cast increases required alignment of target type [-Werror=cast-align]
     CFE_SB_TimeStampMsg((CFE_SB_Msg_t *) &to_hk_status);
                         ^
/home/pi/cFS/apps/to_lab/fsw/src/to_lab_app.c:409:20: error: cast increases required alignment of target type [-Werror=cast-align]
     CFE_SB_SendMsg((CFE_SB_Msg_t *)&to_hk_status);
                    ^

To Reproduce
Build on Raspbian.

Expected behavior
No compiler errors.

Code snips
If applicable, add references to the software.

System observed on:
Raspberry Pi Zero W

Additional context
Add any other context about the problem here.

Reporter Info
[email protected]

Apply standard naming convention (TO_LAB...)

Is your feature request related to a problem? Please describe.

to_lab/fsw/src/to_lab_app.c

Line 62 in c20250e

static CFE_EVS_BinFilter_t CFE_TO_EVS_Filters[] = {/* Event ID mask */

to_lab/fsw/src/to_lab_app.c

Line 94 in c20250e

void TO_Lab_AppMain(void)

to_lab/fsw/src/to_lab_app.c

Line 133 in c20250e

void TO_delete_callback(void)

Describe the solution you'd like
Apply standard pattern (TO_LAB...)

Describe alternatives you've considered
None.

Additional context
Requires update to entry point in startup script (nasa/cFE)

Requester Info
Jacob Hageman

Confirm valid PERF_ID use

Originated by abrown4 (69 on babelfish):

cFE reserves 0-31 perf-ids. Need to confirm ci_lab does not use these.

Mark empty slots with invalid msgid, and don't try to unsubscribe all on them

Is your feature request related to a problem? Please describe.
Unsubscribe all currently loops through the entire table unsubscribing, including the MSGID 0x0's (which is a valid MSGID). This causes numerous errors:

EVS Port1 66/1/CFE_SB 12: Unsubscribe Err:No subs for Msg 0x0 on TO_LAB_TLM_PIPE,app TO_LAB_APP

Describe the solution you'd like
Mark as invalid, skip invalid

Describe alternatives you've considered
Keep a count

Additional context
Observed in fixing #71

Requester Info
Jacob Hageman - NASA/GSFC

Enhanced version reporting

Use CI_LAB_VERSION from cfecfs_version_info.h if available and report on NOOP and startup (along with classic version numbering)

Classic version numbering can then just be updated on release, vs for every commit.

Subscribes to MsgId 0x0 256-actual_msgids times

Describe the bug
Loops through the entire table of subscriptions and subscribes, any unset values in the table are 0 so subscribes to MsgId 0 over 200 times.

Shows up multiple times on startup:
EVS Port1 42/1/CFE_SB 7: Duplicate Subscription,MsgId 0x0 on TO_LAB_TLM_PIPE pipe,app TO_LAB_APP

To Reproduce
Any normal run.

Expected behavior
Only subscribe to requested message IDs.

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 227 to 238 in 5adf513

	/* Subscriptions for TLM pipe*/
	for (i = 0; (i < (sizeof(TO_LAB_Subs->Subs) / sizeof(TO_LAB_Subs->Subs[0]))); i++)
	{
	if (CFE_SB_IsValidMsgId(TO_LAB_Subs->Subs[i].Stream))
	status = CFE_SB_SubscribeEx(TO_LAB_Subs->Subs[i].Stream, TO_LAB_Global.Tlm_pipe, TO_LAB_Subs->Subs[i].Flags,
	TO_LAB_Subs->Subs[i].BufLimit);
	if (status != CFE_SUCCESS)
	CFE_EVS_SendEvent(TO_SUBSCRIBE_ERR_EID, CFE_EVS_EventType_ERROR,
	"L%d TO Can't subscribe to stream 0x%x status %i", __LINE__,
	(unsigned int)CFE_SB_MsgIdToValue(TO_LAB_Subs->Subs[i].Stream), (int)status);
	}

System observed on:

• Hardware: cFS Dev 3
• OS: Ubuntu 18.04
• Versions: current bundle

Additional context
Likely due to subscription table conversion to a cFS table.

Reporter Info
Jacob Hageman - NASA/GSFC

Remove deprecated symbol reference

Is your feature request related to a problem? Please describe.
The TO_LAB app references the CFE_ES_SHELL_TLM which is deprecated and scheduled to be removed in the next release

Describe the solution you'd like
Remove this code

Additional context
This is currently within an OMIT_DEPRECATED conditional block - but in general modules shouldn't refer to deprecated items in other modules at all.

This is a prerequisite to nasa/cFE#815

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Remove obsolete comments

Is your feature request related to a problem? Please describe.
End of function comments historically poorly maintained, so not really worth keeping around. Name of a function in comments also frequently gets out of date.

Example of differences (needs full scrub):

to_lab/fsw/src/to_lab_app.c

Line 476 in c20250e

int32 TO_LAB_AddPacket(const TO_LAB_AddPacket_t *data)

to_lab/fsw/src/to_lab_app.c

Line 493 in c20250e

} /* End of TO_AddPkt() */

Describe the solution you'd like
Remove obsolete comments

Describe alternatives you've considered
None

Additional context
None.

Requester Info
Jacob Hageman - NASA/GSFC

Add Testing Tools to the Security Policy

Is your feature request related to a problem? Please describe.
Users are unaware of how cFS/to_lab is tested. By providing this information, transparency is provided to the community which promotes trust.

Describe the solution you'd like
The security policy should inform users what tools are being used to test cFS/to_lab while being cautious of liability issues. To do so, we can state explicitly that our software does not provide liability under the Apache license. The security policy should inform users that they may view the LGTM results. The policy would state that the alerts from LGTM may not be accurate, since they cannot be dismissed.

Add that security report should be emailed.

Additional context
References: https://github.com/thanos-io/thanos/security/policy

Requester Info
Ariel Adams, ASRC Federal

Remove All Packet command causes to_lab to break

Describe the bug
Sending the TO_REMOVE_ALL_PKT command to to_lab causes to_lab to unsubscribe from its own Message ID.
This means that to_lab will no longer respond to any commands and has to be restarted for it to function properly again. We ran into this problem at NASA Ames and figured that it was not intended behavior.

When testing for this bug be aware that it can be semi obscured by the fact that any commands for TO_LAB already on the Software Bus will still be processed by TO_Lab. This means that whether or not commands to TO_LAB sent after a TO_REMOVE_ALL_PKT command succeed is highly timing dependent.

To Reproduce
Steps to reproduce the behavior:

1. Send TO_REMOVE_PKT command to TO_LAB
2. Send any other command to TO_LAB
3. Observe that the command has no effect

Expected behavior
You should not be able to send TO_LAB a command that puts it into a non functional state

Code snips
//This line in to_lab_app.c line 543 is the source of the problem
status = CFE_SB_Unsubscribe(TO_LAB_CMD_MID, TO_LAB_Global.Cmd_pipe);

System observed on:
This bug is independent of the environment cfs is run in

Reporter Info
James Roach - NASA Research Scientist
[email protected]

Previous PR #45 broke some platforms due to type mismatch

Describe the bug
A recent change in pull request #45 changed the TO_LAB_init function prototype to return an int32 type here:

to_lab/fsw/src/to_lab_app.c

Line 83 in 7e7dc4b

int32 TO_LAB_init(void);

However the function is actually defined later here:

to_lab/fsw/src/to_lab_app.c

Line 158 in 7e7dc4b

int TO_LAB_init(void)

This results in error if int and int32 are not actually the same type.

To Reproduce
Build on any platform where int and int32 are not the same type (e.g. 32 bit RTEMS, for example).

Expected behavior
Declaration should match definition, and it should build cleanly.

System observed on:
RTEMS 4.11.3 (cross)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Implement Coding Standard Rules in CodeQL

Is your feature request related to a problem? Please describe.
CodeQL does not use JPL rules, which is used in the upcoming coding standard.

Describe the solution you'd like
Implement JPL rules for CodeQL. Continue using the security queries, but keep them separate from the JPL results. Can use two different workflows, one for the coding standard and one for the security queries.

Describe alternatives you've considered
Might be able to use one workflow, as long as the results can be easily identified as a coding standard issue or security issue.

Additional context
JPL queries are found here: https://github.com/github/codeql/tree/main/cpp/ql/src/JPL_C

Requester Info
Ariel Adams, ASRC Federal

Remove references to "CCSDS" structures

Is your feature request related to a problem? Please describe.
Applications should NOT refer to the "CCSDS" data types and macros, as there should be no assumption of a particular message framing type at this level.

Describe the solution you'd like
Use the abstract types provided in cfe_sb.h rather than directly using ccsds.h types.

Additional context
Related to nasa/cFE#554

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Add Build name and Build number to version.h

Is your feature request related to a problem? Please describe.
Need a better way to describe versions during development

Describe the solution you'd like
Add Build name and Build number to version.h
As discussed, we will add a a build name string and a continuously incrementing build number to version.h

Additional context
See notes from CCB: https://github.com/nasa/cFS/wiki/Community-CCB-Agenda:-July-01-2020

Requester Info
Gerardo E. Cruz-Ortiz, NASA-GSFC

Remove PktSize from add packet command

Is your feature request related to a problem? Please describe.
PktSize is unused

Describe the solution you'd like
Remove from command

Describe alternatives you've considered
None

Additional context
Observed in testing #71

Requester Info
Jacob Hageman - NASA/GSFC

Update for suggested alignment enforcement pattern (nasa/cFE#1009)

Is your feature request related to a problem? Please describe.
See nasa/cFE#1009, inconsistent pattern

Describe the solution you'd like
Match suggestion in nasa/cFE#1009, use the "raw" message cmd/tlm types in definition.

Describe alternatives you've considered
None

Additional context
nasa/cFE#1009

Requester Info
Jacob Hageman - NASA/GSFC

Typos in documentation, event message, and comments

Is your feature request related to a problem? Please describe.
Found multiple typos throughout the codebase

Describe the solution you'd like
Correct grammar and spelling errors

Describe alternatives you've considered
None

Additional context
Retroactive issue for #101

Update to use OSAL socket API

Is your feature request related to a problem? Please describe.
Currently uses cFE supplied network_includes.h and not the abstracted OSAL calls

Describe the solution you'd like
Update to use OSAL

Describe alternatives you've considered
None

Additional context
See osapi-os-net.h and/or OSAL API.

Requester Info
Jacob Hageman - NASA/GSFC

CI updates - add static analysis and format in workflow

Is your feature request related to a problem? Please describe.
Travis-CI not transitioned to github actions

Describe the solution you'd like
Transition CI

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Release Prep

Is your feature request related to a problem? Please describe.
Updates for release:

• Updated README
• removed custom license document
• Updated copyright release version cFE 6.6 -> 6.7

Requester Info
Jacob Hageman - NASA/GSFC

TO_LAB should better follow cmd/tlm patterns in other modules

Is your feature request related to a problem? Please describe.
The TO_LAB implementation currently does not adhere to the command/telemetry processing patterns established in CFE core and other modules.

Describe the solution you'd like

• Each command handler should be its own function with its own distinct structure type that is passed in to it
• Housekeeping should put its payload into a separate sub-structure called "Payload"
• Telemetry/Command naming conventions documented in CFE should be adhered to

Additional context
Part of the reason for some of these patterns is they help future-proof the code and also help avoid issues like #21.

Requester Info
Joseph Hickey, Vantage Systems Inc.

Fix Pipe ID printf to be strict type-safe compatible

Is your feature request related to a problem? Please describe.
The CFE_SB_PipeId_t type is not a simple/plain integer if strict types are enabled. This trips up a printf statement in TO_LAB here where it tries to print the TO_LAB_Global.Tlm_pipe value:

/home/joe/code/cfecfs/github/apps/to_lab/fsw/src/to_lab_app.c:507:77: error: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘CFE_SB_PipeId_t’ [-Werror=format=]
  507 |                           "L%d TO Can't Unsubscribe to Stream 0x%x on pipe %d, status %i", __LINE__,
      |                                                                            ~^
      |                                                                             |
      |                                                                             int
  508 |                           (unsigned int)CFE_SB_MsgIdToValue(pCmd->Stream), TO_LAB_Global.Tlm_pipe, (int)status);
      |                                                                            ~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                         |
      |                                                                                         CFE_SB_PipeId_t

Describe the solution you'd like
Use the CFE_RESOURCEID_TO_ULONG() macro to get the simple value, and use %lu conversion specifier in printf.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Remove MKS flags from comments

$Id, $Date, $Revision, $Log, etc all no longer useful and slightly misleading since they don't get updated.

Reuse CodeQL, Format Checker, and Static Analysis Workflows

Is your feature request related to a problem? Please describe.
When needing to change workflows, one must create an issue and PR for each submodule. This feature would reduce duplication.

Describe the solution you'd like
To reuse workflows, the targeted workflow must include workflow_call and inputs as seen below.

on:
  push:
  pull_request:
  workflow_call:
    inputs:
      runs-on: 
        description: Platform to execute on
        type: string
        default: ubuntu-latest

Describe alternatives you've considered
Keep it as is.

Additional context
Tested in OSAL, OSAL cFE CodeQL Reuse Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
Tested in OSAL, OSAL CodeQL Reuse Build: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390561827

Requester Info
Ariel Adams, ASRC Federal

Fix doxygen warnings

Describe the bug
Doxygen warnings are generated when building the documentation

To Reproduce
Steps to reproduce the behavior:

1. From cFS/ do make doc
2. Observe the warnings generated in cFS/build/doc/warnings.log

Expected behavior
No warnings should be generated

Reporter Info
Leor Bleier, GSFC\582

Split out to_lab platform config from app header

Originated by abrown4 (60 on babelfish):

The platform-specific config (that I need to change for a deployment) is in the to_lab_app.h, and thus common to all to_lab builds. However, I want to build and deploy multiple cfs instances, each with a to_lab. [It is simple and handy.]

Propose moving the platform-specific info into to_lab_platform_cfg.h, like the other apps.

Overrun warning false alarms in to_lab_app.c

Describe the bug
Out-of-bounds access (OVERRUN) in to_lab_app.c

Expected behavior
Fix overruns

Code snips
Overrunning struct type CFE_MSG_Message_t of 16 bytes by passing it to a function which accesses it at byte offset 19 using argument 20UL.

to_lab/fsw/src/to_lab_app.c

Lines 168 to 169 in 0c6d816

	CFE_MSG_Init(&TO_LAB_Global.HkTlm.TlmHeader.Msg, CFE_SB_ValueToMsgId(TO_LAB_HK_TLM_MID),
	sizeof(TO_LAB_Global.HkTlm));

Overrunning struct type CFE_MSG_Message_t of 16 bytes by passing it to a function which accesses it at byte offset 79 using argument 80UL.

to_lab/fsw/src/to_lab_app.c

Lines 399 to 400 in 0c6d816

	CFE_MSG_Init(&TO_LAB_Global.DataTypesTlm.TlmHeader.Msg, CFE_SB_ValueToMsgId(TO_LAB_DATA_TYPES_MID),
	sizeof(TO_LAB_Global.DataTypesTlm));

Overrunning array PipeName of 16 bytes by passing it to a function which accesses it at byte offset 19.

to_lab/fsw/src/to_lab_app.c

Line 199 in 0c6d816

status = CFE_SB_CreatePipe(&TO_LAB_Global.Cmd_pipe, PipeDepth, PipeName);

Overrunning array ToTlmPipeName of 16 bytes by passing it to a function which accesses it at byte offset 19.

to_lab/fsw/src/to_lab_app.c

Line 210 in 0c6d816

status = CFE_SB_CreatePipe(&TO_LAB_Global.Tlm_pipe, ToTlmPipeDepth, ToTlmPipeName);

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal

TO_LAB App only receiving NOOP commands

Describe the bug
After updating to the most recent cFS packages (git pull) and recursively updating the submodules, all commands from GroundSystem.py to TO_LAB are being interpreted as NOOPS. First saw this with requesting output enabled but then verified that all commands are being seen as NOOPS. Outputs of git pull are below capturing

GroundSystem.py Output:
Host: 127.0.0.1
Port: 1234
Pkt ID: 0x1880
sending data to '127.0.0.1' (IP : 127.0.0.1); port 1234
Data to send:
0x18 0x80 0xC0 0x00 0x00 0x01 0x00 0x06

CFE Output
EVS Port1 42/1/CFE_TIME 21: Stop FLYWHEEL
EVS Port1 42/1/TO_LAB_APP 18: No-op command

Same command with previous build yields the below and telemetry beings to flow.
EVS Port1 42/1/CFE_TIME 21: Stop FLYWHEEL
EVS Port1 42/1/TO_LAB_APP 3: TO telemetry output enabled for IP

To Reproduce
git pull to latest and run both cFE and GroundSystem.py

Expected behavior
Expected a TO_OUTPUT_ENABLE

Code snips
allen@akum-home-lt:~/repos/cFS/missionxyz$ git pull
remote: Enumerating objects: 22, done.
remote: Counting objects: 100% (22/22), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 65 (delta 12), reused 20 (delta 11), pack-reused 43
Unpacking objects: 100% (65/65), done.
From https://github.com/nasa/cFS
69e18e5..788b8d6 master -> origin/master

• [new branch] gh-pages -> origin/gh-pages
• [new branch] integration-candidate -> origin/integration-candidate
  Fetching submodule apps/ci_lab
  From https://github.com/nasa/ci_lab
• [new branch] integration-candidate -> origin/integration-candidate
  3ad9a10..fe9e3ef master -> origin/master
  Fetching submodule apps/sample_app
  From https://github.com/nasa/sample_app
• [new branch] integration-candidate -> origin/integration-candidate
  1f84f20..b956292 master -> origin/master
  Fetching submodule apps/sample_lib
  From https://github.com/nasa/sample_lib
• [new branch] integration-candidate -> origin/integration-candidate
  f499730..33efec3 master -> origin/master
  Fetching submodule cfe
  From https://github.com/nasa/cFE
• [new branch] integration-candidate -> origin/integration-candidate
  d6d944c..60a5f65 master -> origin/master
  Fetching submodule osal
  From https://github.com/nasa/osal
• [new branch] integration-candidate -> origin/integration-candidate
  2284a6f..7d9c4c8 master -> origin/master
  Fetching submodule psp
  From https://github.com/nasa/PSP
• [new branch] integration-candidate -> origin/integration-candidate
  621abba..12e2607 master -> origin/master
  Fetching submodule tools/cFS-GroundSystem
  From https://github.com/nasa/cFS-GroundSystem
• [new branch] integration-candidate -> origin/integration-candidate
  c982339..9d4b155 master -> origin/master
  Updating 69e18e5..788b8d6
  Fast-forward
  .lgtm.yml | 31 ++++++++++++++++---------------
  .travis.yml | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
  README.md | 10 ++++------
  apps/ci_lab | 2 +-
  apps/sample_app | 2 +-
  apps/sample_lib | 2 +-
  cfe | 2 +-
  osal | 2 +-
  psp | 2 +-
  tools/cFS-GroundSystem | 2 +-
  10 files changed, 120 insertions(+), 35 deletions(-)

System observed on:

• Docker build
• OS: Ubuntu

Additional context
N/A

Reporter Info
Allen Kummer - Self

Remove references to CFE_ES_RegisterApp

Is your feature request related to a problem? Please describe.
As part of nasa/osal#853 and nasa/cFE#1215 the registration APIs are getting fully deprecated and removed. Applications no longer need to call OS_TaskRegister, CFE_ES_RegisterApp, or CFE_ES_RegisterChildTask.

Describe the solution you'd like
Remove references to these functions.

Additional context
Will be required with nasa/osal#853 and nasa/cFE#1215

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Update CFE_MSG_Message_t conversions to use CFE_MSG_PTR macro

Is your feature request related to a problem? Please describe.
In nasa/cFE#1966 introduces a CFE_MSG_PTR macro which converts a cmd/tlm header object to a CFE_MSG_Message_t* pointer, which is intended to be used rather than assuming a specific member name (e.g. .Msg).

Describe the solution you'd like
Use the macro instead of assuming .Msg member name.

Additional context
Required when using generated headers, as the member name may not be "Msg" or may be further encapsulated.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Applications should use all-inclusive "cfe.h" header

Is your feature request related to a problem? Please describe.
The CFE documentation recommends that applications use the supplied cfe.h header which in turn provides all CFE core, PSP, and OSAL APIs as well as mission config.

Because some header names are getting changed in nasa/cFE#1203, including the headers individually becomes a problem.

Describe the solution you'd like
Change to using the cfe.h all-inclusive header, which makes ci_lab work with the new directory structure, and should avoid future issues, and it matches what the documentation recommends.

Describe alternatives you've considered
Change cfe_msg_api.h -> cfe_msg.h

Additional context
Needed for nasa/cFE#1203

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Add Contributing Guide

Is your feature request related to a problem? Please describe.
Add a contributing guide for the to_lab repo.

Describe the solution you'd like
Create a contributing guide markdown file. In the guide, add a link to the cFS contributing guide.

Requester Info
Ariel Adams, ASRC Federal

Workflows overly restrictive run, missing duplicate check, format job name incorrect, remove --quiet from cppcheck

Is your feature request related to a problem? Please describe.
Branch restriction unnecessary:

to_lab/.github/workflows/codeql-build.yml

Lines 3 to 7 in 0c6d816

	on:
	push:
	pull_request:
	branches:
	- main

Branch restriction unnecessary, missing duplicate check, incorrect job name:

to_lab/.github/workflows/format-check.yml

Lines 4 to 12 in 0c6d816

	on:
	push:
	branches:
	- main
	pull_request:
	jobs:
	static-analysis:

Branch restriction unnecessary, missing duplicate check:

to_lab/.github/workflows/static-analysis.yml

Lines 4 to 12 in 0c6d816

	on:
	push:
	branches:
	- main
	pull_request:
	jobs:
	static-analysis:

Remove --quiet flag to report files processed:

to_lab/.github/workflows/static-analysis.yml

Line 26 in 0c6d816

run: cppcheck --force --inline-suppr --quiet . 2> cppcheck_err.txt

Describe the solution you'd like
Fix

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Data instantiated in to_lab_sub_table.h is a standards violation

Is your feature request related to a problem? Please describe.
Headers define, c code instantiates per coding standard

Describe the solution you'd like
Move and change to a c file. Also confuses "table" concept, since this isn't a real table. Maybe make it one?

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Remove dependencies on deprecated cFE elements

With:
cfe/CMakeLists.txt:add_definitions("-D_ENHANCED_BUILD_ -DCFE_OMIT_DEPRECATED_6_6")
build errors:

n file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:80:0:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/platform_inc/to_lab_sub_table.h:81:14: error: ‘CFE_EVS_EVENT_MSG_MID’ undeclared here (not in a function)
             {CFE_EVS_EVENT_MSG_MID, {0,0},  32},
              ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_Lab_AppMain’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:120:40: error: ‘CFE_ES_APP_RUN’ undeclared (first use in this function)
    uint32                  RunStatus = CFE_ES_APP_RUN;
                                        ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:120:40: note: each undeclared identifier is reported only once for each function it appears in
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:120:40: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_init’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:187:22: error: ‘CFE_EVS_BINARY_FILTER’ undeclared (first use in this function)
                      CFE_EVS_BINARY_FILTER);
                      ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:187:22: warning: passing argument 3 of ‘CFE_EVS_Register’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:162:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_Register (void                 *Filters,           /* Pointer to
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:203:47: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_CRCMDPIPE_ERR_EID,CFE_EVS_ERROR, "L%d TO Can't crea
                                               ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:203:47: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:209:45: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
        CFE_EVS_SendEvent(TO_TLMPIPE_ERR_EID,CFE_EVS_ERROR, "L%d TO Can't create
                                             ^
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:222:51: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
            CFE_EVS_SendEvent(TO_SUBSCRIBE_ERR_EID,CFE_EVS_ERROR,"L%d TO Can't s
                                                   ^
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:231:41: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
     CFE_EVS_SendEvent (TO_INIT_INF_EID, CFE_EVS_INFORMATION,
                                         ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:231:41: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_StartSending’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:251:44: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
     CFE_EVS_SendEvent(TO_TLMOUTENA_INF_EID,CFE_EVS_INFORMATION,"TO telemetry ou
                                            ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:251:44: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_process_commands’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:289:59: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
                        CFE_EVS_SendEvent(TO_MSGID_ERR_EID,CFE_EVS_ERROR, "L%d T
                                                           ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:289:59: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_exec_local_command’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:314:47: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
             CFE_EVS_SendEvent(TO_NOOP_INF_EID,CFE_EVS_INFORMATION, "No-op comma
                                               ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:314:47: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:344:49: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
             CFE_EVS_SendEvent(TO_FNCODE_ERR_EID,CFE_EVS_ERROR, "L%d TO: Invalid
                                                 ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:344:49: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_openTLM’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:433:50: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_TLMOUTSOCKET_ERR_EID,CFE_EVS_ERROR, "L%d, TO TLM so
                                                  ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:433:50: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_AddPkt’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:454:44: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_ADDPKT_ERR_EID,CFE_EVS_ERROR, "L%d TO Can't subscri
                                            ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:454:44: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:457:44: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_ADDPKT_INF_EID,CFE_EVS_INFORMATION, "L%d TO AddPkt
                                            ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:457:44: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_RemovePkt’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:475:47: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_REMOVEPKT_ERR_EID,CFE_EVS_ERROR,"L%d TO Can't Unsub
                                               ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:475:47: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:478:47: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
        CFE_EVS_SendEvent(TO_REMOVEPKT_INF_EID,CFE_EVS_INFORMATION,"L%d TO Remov
                                               ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:478:47: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_RemoveAllPkt’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:498:57: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
              CFE_EVS_SendEvent(TO_REMOVEALLPTKS_ERR_EID,CFE_EVS_ERROR, "L%d TO
                                                         ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:498:57: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:506:49: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
        CFE_EVS_SendEvent(TO_REMOVECMDTO_ERR_EID,CFE_EVS_ERROR, "L%d TO Can't Un
                                                 ^
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:511:48: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
        CFE_EVS_SendEvent(TO_REMOVEHKTO_ERR_EID,CFE_EVS_ERROR, "L%d TO Can't Uns
                                                ^
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:514:48: error: ‘CFE_EVS_INFORMATION’ undeclared (first use in this function)
     CFE_EVS_SendEvent(TO_REMOVEALLPKTS_INF_EID,CFE_EVS_INFORMATION, "L%d TO Uns
                                                ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:514:48: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,
       ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c: In function ‘TO_forward_telemetry’:
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:556:54: error: ‘CFE_EVS_ERROR’ undeclared (first use in this function)
              CFE_EVS_SendEvent(TO_TLMOUTSTOP_ERR_EID,CFE_EVS_ERROR,
                                                      ^
/home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:556:54: warning: passing argument 2 of ‘CFE_EVS_SendEvent’ makes integer from pointer without a cast [-Wint-conversion]
In file included from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.h:49:0,
                 from /home/jhageman/cFS/cFS-dev/apps/to_lab/fsw/src/to_lab_app.c:50:
/home/jhageman/cFS/cFS-dev/cfe/fsw/cfe-core/src/inc/cfe_evs.h:233:7: note: expected ‘uint16 {aka short unsigned int}’ but argument is of type ‘TO_subsciption_t * {aka struct <anonymous> *}’
 int32 CFE_EVS_SendEvent (uint16 EventID,

Implement a Security Policy

Describe the bug
Create a security policy for users on how to report security vulnerabilities.

Expected behavior
The security policy should instruct users on how to report security vulnerabilities and provide them additional contact information for questions and concerns.

Additional context
Additional sections that may be included:

• What to expect security-wise such as what type of testing is done
• Address privacy concerns
• Supported versions
• License
• Known vulnerabilities

References to Public Security Policies:
https://github.com/thanos-io/thanos/security/policy
https://github.com/minhealthnz/nzcovidtracer-app/security/policy
https://github.com/odoo/odoo/security/policy

Reporter Info
Ariel Adams, ASRC Federal

App should treat CFE_SB_MsgId_t values as opaque

Is your feature request related to a problem? Please describe.
For compatibility going forward, code should not assume that CFE_SB_MsgId_t is an integer.

Describe the solution you'd like
When dealing with an integer, such as when printing in events/messages or for backward compatibility with MID #define's, the code may use CFE_SB_ValueToMsgId() and CFE_SB_MsgIdToValue() conversion routines.

Additional context
Architecturally, the CFE_SB_MsgId_t is supposed to be an opaque/abstract value that identifies an endpoint on the software bus routing domain. The specific meaning of integer values is already different in an "extended header" (CCSDS v2) build vs. the standard header build. Therefore apps should never make assumptions regarding the specific integer values, and all introspection of CFE_SB_MsgId_t values should be through the CFE SB API only.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Hardcoded queue depth of 64

Describe the bug
TO_LAB creates a queue depth of 64, which is beyond the limit of some queue implementations.

To Reproduce
Run TO_LAB on a system that does not allow a queue depth of 64.

Expected behavior
Should not hard code a large queue depth that could be beyond the implementation limit.

Code snips

to_lab/fsw/src/to_lab_app.c

Line 179 in 545710c

ToTlmPipeDepth = 64;

System observed on:
Ubuntu 20.04, after enabling max depth enforcement in OSAL.

Additional context
If the goal is to create a deep queue, then use OS_MAX_QUEUE_DEPTH.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Remove classic build support

Only supporting cmake build going forward