Issues after Update

[natesymer]

Issues after Update

[natesymer]

Shlby,

First of all, thanks for the email! I'm working on a new version of FHSTwitterEngine that doesn't use OAuthConsumer, a version that uses plain old NSMutableURLRequest. There are a number of issues with OAuthConsumer, and they became painfully obvious with the updates to statuses/update_with_media. I also found a way to make requests dramatically smaller, ergo faster.

The demo app is royally broken, and really, it doesn't matter. I'll eventually work on a new demo, but it's of relatively low priority. The actual use of FHSTwitterEngine is up to you. Its use is clearly explained (and demonstrated) in the README.

Also, I don't quite understand the language of your last paragraph, care to say it again in more clear and technical language? (Because you don't call delegates on blocks)

Thanks for your interest in FHSTwitterEngine,

• Nate

On Aug 27, 2013, at 5:08 AM, Shlby Puerto [email protected] wrote:

Hello Nath,

I found some issues after the update specially with Login, Logout

Before, when logging out I use [engine clearAccessToken]
and
NSArray *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookies];

[cookies enumerateObjectsUsingBlock:^(NSHTTPCookie *cookie, NSUInteger idx, BOOL *stop)
{
[[NSHTTPCookieStorage sharedHTTPCookieStorage] deleteCookie:cookie];
}];
and it works fine.. I can still login back but now I can't. On you're logout button you only changed the label and resigned the keyboard.
Is there a way we can login and logout properly? Like the one you had before.

Another is, when I call delegates on the block in showOAuthLogin, with handler, even if used the block method to retain "self" it is still released.

Shlby
—
Reply to this email directly or view it on GitHub.

[shlbypuerto]

Nate,

"Another is, when I call delegates on the block in showOAuthLogin, with handler, even if used the block method to retain "self" it is still released."

Umm, it's hard to explain but here goes, there's something on the block in showOAuthLogin that only success shown. Any other variable that we want to log becomes nil. And we cannot call any functions from there.

Example :
__weak someClass *dp = self;
__block someClass *dp2 = self;
NSString *string = asd;

[self.engine showOAuthLoginControllerFromViewController:vc withCompletion:^(BOOL success) {

    if (success) {
      [self someFunction];
      [db someFunction];
      [dp2 someFunction];
      NSLog(@"%@",string);

    } else {

    }

}];

-(void)someFunction{}

// someFunction won't be called
// None of the functions will be called even if we have applied the block
// same goes with variables. string becomes nil.

P.S. Before everything worked fine.

• Shlby

[natesymer]

This will be fixed in the next commit or when I merge a feature branch. I am aware of this, and I have implemented a solution.