Incorrect selection of package version

[nathanhleung]

Incorrect selection of package version

[ljharb]

I would expect the npm install command to be @^7 and not @7.0.0 or @7.4.0 - that seems like a bug.

[ljharb]

You could use ^3.8 for that tho, any reason you’re not?

[erhhung]

@ljharb I think ^3.8 would still get parsed into @3.8.0, which is a non-existent version. Regardless of the semver syntax, my point is that this tool should handle whatever that is considered valid in a package.json file.

[erhhung]

BTW, my workaround to this issue seems to completely obviate the need for install-peerdeps:

npm info <package> peerDependencies --json | jq -r 'keys[] as $k | "\($k)@\"\(.[$k])\""' | xargs npm install --save-dev

[ljharb]

No, it wouldn’t - the caret is an identical (and simpler and more widely understood) range than the one you have.

[ocean90]

I think I have a similar case where ^7 is transformed to 7.0.0 instead of the latest in the 7.x branch.

Example:

❯ npx install-peerdeps --dev @wordpress/eslint-plugin --dry-run
install-peerdeps v2.0.3
This command would have been run to install @wordpress/eslint-plugin@latest:
npm install @wordpress/[email protected] [email protected] --save-dev --registry https://registry.npmjs.org

Source: https://github.com/WordPress/gutenberg/blob/acc6dbea78ab3b8dd5436a57bc0c2d4808ec6756/packages/eslint-plugin/package.json#L44

I'm expecting to get [email protected] here. Is that expectation incorrect?

[karlhorky]

Yeah, I believe this is a bug - I think it may be causing facebook/create-react-app#10465 reported by @uebriges.

[karlhorky]

Just tested with @uebriges, and it seems this is indeed a problem.

We tested on a Windows 10 machine - not sure if this is a relevant detail.

Failing Repro

Reproduction 1 uses install-peerdeps to install the peer dependencies of eslint-config-react-app. When react-scripts start is run using yarn start, create-react-app crashes, saying that the versions of babel-eslint and eslint do not match the version from react-scripts.

mkdir reproduction
cd reproduction
npx create-react-app .
npx install-peerdeps --yarn --dev eslint-config-react-app
yarn start

Succeeding Repro

Reproduction 2 uses a manual yarn add --dev installation command to install the version ranges from the package.json for eslint-config-react-app. The start script runs without any problems:

mkdir reproduction-two
cd reproduction-two
npx create-react-app .
yarn add --dev eslint-config-react-app @typescript-eslint/eslint-plugin@^4.0.0 @typescript-eslint/parser@^4.0.0 babel-eslint@^10.0.0 eslint@^7.5.0 eslint-plugin-flowtype@^5.2.0 eslint-plugin-import@^2.22.0 eslint-plugin-jsx-a11y@^6.3.1 eslint-plugin-react@^7.20.3 eslint-plugin-react-hooks@^4.0.8 eslint-plugin-jest@^24.0.0
yarn start

[nathanhleung]

@karlhorky really appreciate your testing here, glad we're squashing all these bugs! Opened #126 which should hopefully fix -- can you let me know if that works for you?

[karlhorky]

Sure! @uebriges and I will test: #126 (comment)

[karlhorky]

Ah seems like this solution in #126 doesn't work after all (installing the eslint-config-react-app peer deps in a new create-react-app project with [email protected] just failed on Windows).

You can see this with this example dependency:

eslint-config-react-app

    "@typescript-eslint/parser": "^4.0.0",

Source: https://unpkg.com/browse/[email protected]/package.json

Installed via [email protected]

    "@typescript-eslint/parser": "4.0.0",

Latest version of @typescript-eslint/parser

4.14.2

Source: https://www.npmjs.com/package/@typescript-eslint/parser

---

Let me know if I should open a new issue for this.

[zhiqingchen]

same problem on a Windows 11 machine