Comments (6)
No plans, but someone else can surely do that and I'll be happy to merge the pull request.
from librets.
@jazzklein has this issue been resolved? with this pull request #48?
thanks
from librets.
No, that just exposed some existing functionality to Windows.
from librets.
@jazzklein - I'm happy to take a crack at adding support for supporting the "Action" request argument. What would be the best approach though?
- If the RETS version is set to 1.8 then use "Action" instead of "Type".
This would follow the spec for 1.8, but this would break for any RETS servers out there that always require the "Type" parameter (even when using version 1.8).
- Add an option that indicates whether to use "Action" or "Type".
This would allow the client to decide if the request should use "Action" or "Type" themselves. There could also be an "auto" option that would switch based on the RETS version. I'm assuming the "default" option should continue to use "Type" (as that is a break change)?
- Add an option for setting the "Action" parameter independently of the "Type" parameter.
This is probably the easiest change that would fix this, but does mean the client could send requests with both "Type" and "Action" parameters. That may not be a bad thing.
from librets.
@codenaked I've always tried to follow both the spec and the "do no harm" philosophy. So, anything that breaks existing usage should not be considered. I think your 3rd point is probably the best alternative.
I'll be happy to merge things if there are no other objections to what you do.
from librets.
@jazzklein - Any chance you can merge Darren Kopp's PR and put out a build? I would be eternally grateful! :-)
from librets.
Related Issues (20)
- C# looping using hasnext() does not go through all records HOT 1
- How to install librets to use it with python3.7.X HOT 1
- Old Subversion Vendor Branches Referenced in Documentation HOT 1
- Missing first photoObject for MRIS HOT 6
- The type initializer for 'librets.libretsPINVOKE' threw an exception. HOT 1
- RETS or RESO Web API for keeping local database up to date? HOT 13
- Must pass MODE_NO_SSL_VERIFY as of 1.6.3 HOT 13
- ContentLength required
- Error installing LibRets package 1.6.3 on .Net Core 3.0 HOT 1
- Error after update to 1.6.3 HOT 7
- 1.6.1 or 1.6.3 and TLS 1.2 HOT 25
- Authentication errors tls1.2 HOT 5
- librets won't work with RETS 1.9.0 servers HOT 6
- Windows Build HOT 1
- libRETS-x64 1.6.3 Does not work on Windows Server x64 HOT 4
- c# or vb.net example console applications HOT 1
- libRETS-x64 1.6.3 -503 HOT 1
- java use libRETS HOT 7
- how to install librets.pm module on centos 8 for PERl Script
- RetsSession.Search(query) error: Sequence contains more than one matching element HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from librets.