Giter Site home page Giter Site logo

Comments (6)

jazzklein avatar jazzklein commented on August 16, 2024

No plans, but someone else can surely do that and I'll be happy to merge the pull request.

from librets.

marwanhaddad avatar marwanhaddad commented on August 16, 2024

@jazzklein has this issue been resolved? with this pull request #48?

thanks

from librets.

jazzklein avatar jazzklein commented on August 16, 2024

No, that just exposed some existing functionality to Windows.

from librets.

codenaked avatar codenaked commented on August 16, 2024

@jazzklein - I'm happy to take a crack at adding support for supporting the "Action" request argument. What would be the best approach though?

  1. If the RETS version is set to 1.8 then use "Action" instead of "Type".

This would follow the spec for 1.8, but this would break for any RETS servers out there that always require the "Type" parameter (even when using version 1.8).

  1. Add an option that indicates whether to use "Action" or "Type".

This would allow the client to decide if the request should use "Action" or "Type" themselves. There could also be an "auto" option that would switch based on the RETS version. I'm assuming the "default" option should continue to use "Type" (as that is a break change)?

  1. Add an option for setting the "Action" parameter independently of the "Type" parameter.

This is probably the easiest change that would fix this, but does mean the client could send requests with both "Type" and "Action" parameters. That may not be a bad thing.

from librets.

jazzklein avatar jazzklein commented on August 16, 2024

@codenaked I've always tried to follow both the spec and the "do no harm" philosophy. So, anything that breaks existing usage should not be considered. I think your 3rd point is probably the best alternative.

I'll be happy to merge things if there are no other objections to what you do.

from librets.

codenaked avatar codenaked commented on August 16, 2024

@jazzklein - Any chance you can merge Darren Kopp's PR and put out a build? I would be eternally grateful! :-)

from librets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.