Giter Site home page Giter Site logo

Comments (2)

jpakulski avatar jpakulski commented on June 7, 2024

Just a small followup:

I had a look at the native code that's included and removing a check for UIApplicationStateActive in the didReceiveRemoteNotification:(NSDictionary *)userInfo method fixes my problems. This is a totally naive fix as I did not check the rest of the code and don't really understand why the check was there in the first place:

push-plugin/native-src/ios/PushPlugin/PushManager.m

- (void)my_application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo {
    if (didReceiveOriginalMethod) {
        void (*originalImp)(id, SEL, UIApplication *, NSDictionary *) = didReceiveOriginalMethod;
        originalImp(self, @selector(application:didReceiveRemoteNotification:), application, userInfo);
    }
    NSLog(@"didReceiveNotification");
    
    UIApplicationState appState = UIApplicationStateActive;
    if ([application respondsToSelector:@selector(applicationState)]) {
        appState = application.applicationState;
    }
    
    [Push sharedInstance].notificationMessage = userInfo;
    [Push sharedInstance].isInline = YES;
    [[Push sharedInstance] notificationReceived];
}

Update:

In the above code change

[Push sharedInstance].isInline = YES;

To

[Push sharedInstance].isInline = appState == UIApplicationStateActive;

This sets the "foreground" value inside the received message to a correct value.

from push-plugin.

zbranzov avatar zbranzov commented on June 7, 2024

A fix is released in [email protected]

from push-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.