Giter Site home page Giter Site logo

Comments (3)

natsuk4ze avatar natsuk4ze commented on May 28, 2024

Thank you for your contribution 🤝 @SleepySquash

There is a possibility to make macOS 10.15 the lowest supported version, but before that we need to investigate the API.

I wonder, whether .swift files will build at all

Yes. This is because the main function for saving, PHAssetChangeRequest in photo-kit, is only available on macOS 10.15 or later. See #146.
For that reason, 10.14 and below will not be added to support at all at this time.

macOS targets lower than 11.0, and instead throw UnsupportedError
Perhaps Gal.isSupported() might be added to know, whether gal is available

This does not look good for me. Users should check the supported version of a plugin and expect to be able to use all features within that version. They do not expect to get errors only with older versions.

from gal.

SleepySquash avatar SleepySquash commented on May 28, 2024

@natsuk4ze, oh, sorry for not noticing the issue you mentioned, it's my mistake, I apologise for your time taken.

Thank you for the detailed answer! After investigating the macOS Big Sur supported devices, I suppose, it doesn't really make sense to target 10.15 instead of 11.0. Main reason I hoped for version downgrade is Mojave, as it is the last macOS to support 32 bit applications, and some users may stick with it only because of that. And since that doesn't work out, I guess, everything is ok.

They do not expect to get errors only with older versions

Well, I do agree. It is indeed better to know the package works on every OS version the application is built for.

I'm closing the issue. Thank you for your time!

from gal.

natsuk4ze avatar natsuk4ze commented on May 28, 2024

I'm closing the issue. Thank you for your time!

You're welcome. Thanks again for your contribution 😊 @SleepySquash

from gal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.