Giter Site home page Giter Site logo

Comments (9)

natw avatar natw commented on September 13, 2024

Huh, weird. Thanks, I'll look into that.

from keyboard_cat.vim.

natw avatar natw commented on September 13, 2024

I "fixed" this here: 444d041. I'm not sure why my first instinct was to use a literal ^M, but \n seems to work fine.

I'll send them a bug report about the forking issue, though. Data integrity is kind of a thing.

from keyboard_cat.vim.

rgbkrk avatar rgbkrk commented on September 13, 2024

I'm not sure why my first instinct was to use a literal ^M, but \n seems to work fine.

That's ok. Not being a master of vim scripting, I wasn't sure how to fix it but the forking issue led right to why it wouldn't display.

Data integrity is kind of a thing.

Looking forward to the bug report for the :octocat:

from keyboard_cat.vim.

natw avatar natw commented on September 13, 2024

I can't reproduce this. What editor are you using? Cause looking at rgbkrk@d73bd59, it looks like you switched out the carriage return for the newline in your first commit.

from keyboard_cat.vim.

rgbkrk avatar rgbkrk commented on September 13, 2024

Oddly enough, I was just using the GitHub UI (chrome on Ubuntu Linux) to edit the file directly. When I was about to commit, I saw that a newline appeared. Oh. So perhaps Chrome is converting it... 😦 That would make sense.

Originally the steps to re-produce were:

  • Click the keyboard_ cat.vim file in GitHub
  • Click Edit
  • Make a minimal commit
  • Extra newline inserted.

The weird thing though is that when I was reproducing this (before you fixed it), it wouldn't let me make an "empty" commit. That is, I had not changed anything yet the commit button was greyed out.

from keyboard_cat.vim.

rgbkrk avatar rgbkrk commented on September 13, 2024

Try editing https://github.com/rgbkrk/ctrl-m/blob/master/trial.vim as a demo. GitHub will fork it for you.

from keyboard_cat.vim.

natw avatar natw commented on September 13, 2024

Yeah, it looks like it's the web editor that's interpreting a carriage return as a newline

Here's the edit I made: natw/ctrl-m@97c910a

Given that, I can't really get too riled up about this one.

from keyboard_cat.vim.

rgbkrk avatar rgbkrk commented on September 13, 2024

Given that, I can't really get too riled up about this one.

Yeah.

Of course, file view is borken as well.

from keyboard_cat.vim.

rgbkrk avatar rgbkrk commented on September 13, 2024

Closed this as it was a GitHub editor issue and @natw fixed it in 444d041.

from keyboard_cat.vim.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.