Giter Site home page Giter Site logo

Comments (3)

itdependsnetworks avatar itdependsnetworks commented on June 25, 2024

For Golden Config, we should approach it this way. nautobot/nautobot-app-golden-config#683

For Nautobot Core in general, I am not sure what the best path forward is.

from nautobot.

glennmatthews avatar glennmatthews commented on June 25, 2024

As far as I understand the original issue, the current biggest problem is gitpython-developers/GitPython#718, which may be mitigated by ensuring that we explicitly delete any git.Repo objects when done with them, most likely either by explicitly calling Repo.__del__() at the end of our ensure_git_repository() utility function, or by calling Repo.__del__() when a nautobot.core.utils.git.GitRepo instance is deleted.

Shallow clone might be a nice feature to mitigate disk space requirements but to the best of my knowledge the memory leak is the current problem to solve.

from nautobot.

glennmatthews avatar glennmatthews commented on June 25, 2024

Thus far in some manual testing I'm unable to trigger the GitPython memory leak. Even after re-cloning a repository 1000 times, or cloning 100 separate repos, there are no extraneous open file handles and no apparent increase in memory consumption. This leads me to believe that my previous understanding was perhaps incorrect, and perhaps the "OOM" referenced in the issue was due to disk space exhaustion rather than memory exhaustion -- @mattmiller87 can you provide any additional clarity?

from nautobot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.