Optimization: GetAccountAuthorizationDetails

[nccgroup]

Optimization: GetAccountAuthorizationDetails

[ncc-erik-steringer]

I hadn't noticed this API before. It definitely would knock out a bunch of the work that goes into the graphing portion. The only concern I have is scaling, but the API hints that pagination is available.

[danieladams456]

Yeah, I had just been using the CLI before. Trying it with the API it really was 13 pages. Still not bad for 600 roles and associated policies.

Not the most elegant, but easy to reason about. All these accumulate independently over the pages.

def do_pull():
    # temporary accumulator variables
    UserDetailList = []
    GroupDetailList = []
    RoleDetailList = []
    Policies = []

    for res in iam.get_paginator('get_account_authorization_details').paginate():
        UserDetailList.extend(res['UserDetailList'])
        GroupDetailList.extend(res['GroupDetailList'])
        RoleDetailList.extend(res['RoleDetailList'])
        Policies.extend(res['Policies'])

    return {
        'UserDetailList': UserDetailList,
        'GroupDetailList': GroupDetailList,
        'RoleDetailList': RoleDetailList,
        'Policies': Policies,
    }

[ncc-erik-steringer]

Aiming to fix this with #36 and deploy the change in the next micro version.

[ncc-erik-steringer]

Looping back around here, I think I'm gonna aim to implement this now in v1.1.0 to address #41 since the iam:ListUsers API ain't gonna return it.

[ncc-erik-steringer]

Completed in 5828a87 for eventual release of v1.1.0.