Image attachments should use original file name rather than "Mail Attachment.jpeg"

[sdenaro]

Image attachments should use original file name rather than "Mail Attachment.jpeg"

[sdenaro]

I can probably test it this weekend as I don't have golang on the server I use to run it.

[Necoro]

You are right. Note to self: set "filename=" in the Content-Disposition.

@sdenaro: Out of curiosity: What kind of mail client are you using? Because the ones I have at hand, do not show the images as an explicit attachment at all (due to Content-Disposition: inline)

[Necoro]

Btw: What version of the old feed2imap are you using? They removed image attachments 6 years ago:
feed2imap/feed2imap@a34999e

(And now I know why the remaining code never made sense anymore ...)

[sdenaro]

I am using your fork with some changes, including the older code for filenames. I was keeping an ancient version of ruby2.3 just to run it.

[Necoro]

@sdenaro: Does the change in master fulfill your needs?

[Necoro]

Thanks!

Note that you don't need Go installed on the system you intend to run a go program on. Using $GOOS and $GOARCH (Details) you can cross-compile on any platform for any other platform and will get the final binary you need for running.
Example to compile for Win@ARM under Linux: GOOS=windows GOARCH=arm go build

[Necoro]

Btw: I just fixed the build process, so doing go install github.com/Necoro/feed2imap-go@master will also just give you the current feed2imap-go in ~/go/bin

[sdenaro]

I had a little problem getting it working

When I run go install github.com/Necoro/feed2imap-go@master

I get package github.com/Necoro/feed2imap-go@master: can only use path@version syntax with 'go get'

So I tried the go get options with go get github.com/Necoro/feed2imap-go@master and I got this error

go: github.com/Necoro/feed2imap-go master => v1.2.1-0.20211029115210-4b59d684c18e go/pkg/mod/github.com/!necoro/[email protected]/internal/feed/template/template.go:4:2: package embed is not in GOROOT (/usr/local/go/src/embed)

Any idea what I am doing wrong?

[Necoro]

Yeah, you need Go 1.17.

But I'll do a leap of faith here and just release it as-is: In the worst case, I'll just release another one.

/edit: There you go

[sdenaro]

I built and tested the package using 1.17 and then noticed you put in a new version.

it works perfectly.