Giter Site home page Giter Site logo

Comments (2)

nemequ avatar nemequ commented on August 29, 2024

Maybe I'm misunderstanding the point of this report, but it seems like µnit already does what you're talking about. You've elided the portion which shows the expanded value. The full string should look something like:

assertion failed: SOME_LONG_UGLY_EXPRESSION == 7 (0 == 7)

Both versions are shown because both can be useful in different situations.

from munit.

webstrand avatar webstrand commented on August 29, 2024

I guess I should've included the message I expected:

assertion failed: FOO == 7 (0 == 7)

The problem with reporting the expansion of FOO is that a macro's expansion is often cryptic and doesn't provide any additional information. Also if the expansion contains format strings, or even sequences of characters that parse as flags, at best spurious warnings will be produces and at worst the assertion causes a segmentation fault.

If the current behavior is the desired behavior, I suppose the security issues can be fixed by passing the expansion as a parameter to printf rather than using the preprocessor to concatenate the strings.

from munit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.