[Feature Request] Smart Creation

[neo4j-contrib]

[Feature Request] Smart Creation

[robinedwards]

unique_index and index already handle the indexing. any property where these are used are automatically indexed. (Using the equivalent of get_or_create_index_node under the hood)

I had considered supporting default values for properties which could either contain a constant or a function to call.

def uid_generator():
return uid
uid = StringProperty(default=uid_generator, unique_index=True)

This could be used to create a custom UnqiueID property, it's probably worth mentioning that it's easy to subclass the current properties.

I will add in the hook necessary for default values this evening

[opqopq]

Default value is an excellent idea.
Here the point is more to emulate one py2neo function, which is get_or_create indexed node. The point would be that I can do, in my codeclass Place(StructuredNode): name=StringProperty()
Place.get_or_create(name="Home")#first time-> create the nodePlace.get_or_create(nmae='Home')-> node already exist: just send a reference to it

Date: Wed, 31 Oct 2012 08:39:51 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [neomodel] [Feature Request] Smart Creation (#21)

unique_index and index already handle the indexing. any property where these are used are automatically indexed. (Using the equivalent of get_or_create_index_node under the hood)

I had considered supporting default values for properties which could either contain a constant or a function to call.

def uid_generator():

return uid

uid = StringProperty(default=uid_generator, unique_index=True)

This could be used to create a custom UnqiueID property, it's probably worth mentioning that it's easy to subclass the current properties.

I will add in the hook necessary for default values this evening

          —

          Reply to this email directly or view it on GitHub.

[robinedwards]

Hey,

Just pushed support for default values so you can handle uid generation. As it happens we need this feature at work.

What your trying to do with get_or_create is basically the equivalent of:

try:
    p = Person.get(name='tim')
except Person.DoesNotExist:
    p = Person(name='jim')

Which is not too much longer and very easy to read. The issue with get or create is that each item can have multiple properties in an index as opposed to one. Some of those properties are not necessarily unique.

R

[opqopq]

You're right. Indeed, this try/except should be enough.

Date: Thu, 1 Nov 2012 07:50:35 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [neomodel] [Feature Request] Smart Creation (#21)

Hey,

Just pushed support for default values so you can handle uid generation. As it happens we need this feature at work.

What your trying to do with get_or_create is basically the equivalent of:

try:
p = Person.get(name='tim')
except Person.DoesNotExist:
p = Person(name='jim')

Which is not too much longer and very easy to read. The issue with get or create is that each item can have multiple properties in an index as opposed to one. Some of those properties are not necessarily unique.

R

          —

          Reply to this email directly or view it on GitHub.

[opqopq]

Just on remark though: unless mistaken, the 'get' method you're suggesting is not existing in my version. Is it something being developped ?

[pkatseas]

Ah, there's a '.index' missing there. Should be
Person.index.get(name='test')

On Mon, Nov 5, 2012 at 5:39 PM, opqopq [email protected] wrote:

Just on remark though: unless mistaken, the 'get' method you're suggesting
is not existing in my version. Is it something being developped ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-10079973.

[opqopq]

Thanks !