use libgit2?

[neogitorg]

use libgit2?

[TimUntersberger]

Libgit2 seems like a better solution than writing pure cli commands. How could we then do the git command history stuff?

[bfredl]

@TimUntersberger good question. probably command history will handled in Neovim instead (history for ex commands, for instance, like :Neogit split mybranch and whatever)

[TimUntersberger]

Just to make sure, are we talking about the same thing? I am talking about for example: git status --.... this then gets added to the history along with the stdout, stderr and the return code. I guess we could generate them ourselves?

[bfredl]

@TimUntersberger yea I am not sure about that. But it is not "all or nothing", we can still cli as the baseline, and slowly move things to libgit2 one at at time.

[TimUntersberger]

If you want to you can try changing an existing implementation to use libgit2, so we can see how this would work. The easiest one would probably be the status command. Also how can you include luarocks dependencies?

[bfredl]

Also how can you include luarocks dependencies?

We don't know yet 😅 . I will just hack it into my lua path for now, and discuss with a bunch of ppl (you, packer.nvim, neovim core team) how/if/when we will "do" luarocks deps.

[bfredl]

soo it turns out luagit2 is not compatible with libgit2 1.0. I will see how much effort to fix it (probably not too much, as uses LuaNativeObject)

[bfredl]

WIP libgit2/luagit2#9 should be too hard to finish

[TimUntersberger]

should be too hard

Do you mean shouldn't be too hard ? Nice work!

[bfredl]

I cannot into English grammar :]

[TimUntersberger]

No worries :-) I am excited to see how we could use libgit2! Have you tried neogit yet? How do you feel about the notifications? When i initially developed this I thought it might be a bit too much, but I just went with it anyway, because the concept feels really cool.

[bfredl]

actually not, there so much neovim lua stuff that I am being behind on 😅. I first want to do fugitive style Read/WriteBufCmd and a simple gitgutter (but with decorations instead of signs, it is 2020 already). But I will "try" the neogit experience for sure :]

[TimUntersberger]

decorations instead of signs

👀

What exactly do you mean by decorations?

But I will "try" the neogit experience for sure :]

You could experience a few bugs ... 😅

[bfredl]

What exactly do you mean by decorations?

For instance

• highlighting the exact byte range of a diff instead of just the lines
• showing "virtual text" which could be anything (git blame, number of deleted lines, etc etc)