azure:login: make deps explicit

[katcipis]

azure:login: make deps explicit

[i4ki]

got it! Only wondering for real use cases for that. Thanks!

[vitorarins]

I agree completely. But I think it should be subscription instead of service_principal. Am I tripping?

[i4ki]

but then klb users will have to invoke azure_login passing the environment variables anyway.
I'm not against this change, only missing the benefits.

[katcipis]

@tiago4orion why they have to use env vars ? it is not required, we assumed that was the best way. It could be a config file that is loaded from the user HOME (like aws/azure cli).

We can go on using env vars, from another helper function, but it seems like a good idea to have a explicit login function that is not coupled with environment variables.

[katcipis]

Even the name change seems advantageous to me, it is very odd to just call azure_login with no parameters and it just works, or not :-P

azure_login_env would make the env vars explicit and give an option to people who want to handle this differently.

I think @ppizarro is one of these people =)

[katcipis]

@vitorarins it was @lborguetti who called like that, I never inspected in details. I looked here:

https://github.com/NeowayLabs/klb/blob/master/azure/login.sh#L24

And it seems that it is a username...got a little confused. @lborguetti some help ?

[vitorarins]

@katcipis Ok then.

@tiago4orion maybe a use case would be automating resources in more than one subscription.

[ppizarro]

I agree with make deps explicit. This problem occurred with me when I update KLB to version 0.4. Everything stopped to work. I had to discover that azure_login needed a new one environment variable. OK, it's annotated in the Changelog but if we make deps explicit we will help guy's like me that don't read Changelog :(

…

On Apr 28, 2017 19:10, "Vitor Arins" ***@***.***> wrote: @katcipis <https://github.com/katcipis> Ok then. @tiago4orion <https://github.com/tiago4orion> maybe a use case would be automating resources in more than one subscription. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#108 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJdUYX6aCM7RN8IPlBrUDJ9P84I_lhiks5r0mPjgaJpZM4NL5KB> .