Comments (8)
got it! Only wondering for real use cases for that. Thanks!
from klb.
I agree completely. But I think it should be subscription
instead of service_principal
. Am I tripping?
from klb.
but then klb users will have to invoke azure_login
passing the environment variables anyway.
I'm not against this change, only missing the benefits.
from klb.
@tiago4orion why they have to use env vars ? it is not required, we assumed that was the best way. It could be a config file that is loaded from the user HOME (like aws/azure cli).
We can go on using env vars, from another helper function, but it seems like a good idea to have a explicit login function that is not coupled with environment variables.
from klb.
Even the name change seems advantageous to me, it is very odd to just call azure_login with no parameters and it just works, or not :-P
azure_login_env would make the env vars explicit and give an option to people who want to handle this differently.
I think @ppizarro is one of these people =)
from klb.
@vitorarins it was @lborguetti who called like that, I never inspected in details. I looked here:
https://github.com/NeowayLabs/klb/blob/master/azure/login.sh#L24
And it seems that it is a username...got a little confused. @lborguetti some help ?
from klb.
@katcipis Ok then.
@tiago4orion maybe a use case would be automating resources in more than one subscription.
from klb.
from klb.
Related Issues (20)
- Missing return the address pool id when it was created
- Fixing issues to create Managed Disks using CLI 2.0 HOT 2
- bug: regression on vnet and alb HOT 22
- feature: add snapshot support HOT 1
- feature: set session persistence for lb rules HOT 1
- deps: permission denied installing azure HOT 3
- Docker: Missing JQ install HOT 2
- Missing the deps script to install at debian
- Wrong syntax to create a vm with multiple nics
- Missing lb set public ip name
- All functions who creates some resource should be idempotent HOT 9
- Improve the create the SP with roles as args
- feature: moving ALB HOT 3
- Add support to Azure Scaleset
- Unable to install deps with Debian 9
- Ubuntu repository doesn't have the repository files anymore HOT 2
- testing: add tests for azure_snapshot_copy
- testing: add tests for azure_vm_backup_copy
- testing: fix CI failures
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from klb.