Comments (15)
Hey,
Thanks for the awesome component!
I'm still getting this issue with the current version have you pushed your fix to npm?
Cheers
from react-photo-gallery.
@louisdvs i published a new release
from react-photo-gallery.
@neptunian thanks, my layout was still breaking at certain widths (updated to 5.6.2), I changed the value from 1 to 2 and it's not breaking anymore.
// subtract 1 pixel because the browser may round up a pixel
const containerWidth = this.state.containerWidth - 2;
Cheers
from react-photo-gallery.
This is still an issue, in IE 11. I've updated to 5.6.2, I also tried changing containerWidth to 2, 3, even 5 but still doesn't make a difference. The columns still break at certain breakpoints and I end up having one image in a row instead of 3 , and then the other 2 on the next row. @neptunian
from react-photo-gallery.
@marko911 are you not able to update to the very latest version?
from react-photo-gallery.
@neptunian I did update successfully but the problem persists in IE 11. Its fixed in chrome yes but not IE.
from react-photo-gallery.
@marko911 okay i'll look into it, thank you
from react-photo-gallery.
any updates on this @neptunian ?
from react-photo-gallery.
@marko911 i tested in IE11 at various breakpoints and could not get the layout to "break". Did you mess with the CSS at all of the images in an external stylesheet?
from react-photo-gallery.
@neptunian no I didn't change any css , but here check out how it breaks where I use it maybe its something else I didn't think of (scroll to collection) : LINK
from react-photo-gallery.
did you try updating to version 6?
from react-photo-gallery.
Hi, Yes, but still breaking. I've taken my images and properties and ported them into your demo and they don't break in the demo so I am trying to investigate now why it is breaking in my app. Thanks for follow up. @neptunian
from react-photo-gallery.
let me know if you can't find a solution. right now the image sizes are calculated down to fractions of a pixel. it makes it so everything looks very even, but i think i can round it down a bit to leave some "safe space" when things are a bit off for whatever reason.
from react-photo-gallery.
@neptunian You can close this. I've resolved the issue using the new version and a custom image component. There are no issues with your code , thanks for support :)
from react-photo-gallery.
okay cool, well i published a new release anyway getting rid of some decimals that might have helped :)
from react-photo-gallery.
Related Issues (20)
- Lightbox image not centering HOT 3
- Adding attributes
- Handing images when they are missing
- Empty markup rendered using Jest and testing-library HOT 2
- React 17.x support HOT 6
- Rows Gallery Layout problem HOT 1
- Images become stretchy vertically on iPhone Safari HOT 6
- how to change number of image per row?
- How to load many images locally
- This Does not have support for react 17.0 HOT 2
- Additional props for photo
- Is is possible to cover images in gridview? HOT 1
- Caption, and hi-res download
- Add gap property to Gallery HOT 6
- How to add style to images?
- Custom dynamic columns example does not load
- Max image container width and height
- Defaultprops warning
- Can I use it with Angular?
- Update return type for `columns` function prop to `number | undefined`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-photo-gallery.