Giter Site home page Giter Site logo

Comments (15)

louisdvs avatar louisdvs commented on June 3, 2024

Hey,
Thanks for the awesome component!
I'm still getting this issue with the current version have you pushed your fix to npm?
Cheers

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

@louisdvs i published a new release

from react-photo-gallery.

louisdvs avatar louisdvs commented on June 3, 2024

@neptunian thanks, my layout was still breaking at certain widths (updated to 5.6.2), I changed the value from 1 to 2 and it's not breaking anymore.

// subtract 1 pixel because the browser may round up a pixel
const containerWidth = this.state.containerWidth - 2;

Cheers

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

This is still an issue, in IE 11. I've updated to 5.6.2, I also tried changing containerWidth to 2, 3, even 5 but still doesn't make a difference. The columns still break at certain breakpoints and I end up having one image in a row instead of 3 , and then the other 2 on the next row. @neptunian

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

@marko911 are you not able to update to the very latest version?

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

@neptunian I did update successfully but the problem persists in IE 11. Its fixed in chrome yes but not IE.

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

@marko911 okay i'll look into it, thank you

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

any updates on this @neptunian ?

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

@marko911 i tested in IE11 at various breakpoints and could not get the layout to "break". Did you mess with the CSS at all of the images in an external stylesheet?

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

@neptunian no I didn't change any css , but here check out how it breaks where I use it maybe its something else I didn't think of (scroll to collection) : LINK

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

did you try updating to version 6?

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

Hi, Yes, but still breaking. I've taken my images and properties and ported them into your demo and they don't break in the demo so I am trying to investigate now why it is breaking in my app. Thanks for follow up. @neptunian

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

let me know if you can't find a solution. right now the image sizes are calculated down to fractions of a pixel. it makes it so everything looks very even, but i think i can round it down a bit to leave some "safe space" when things are a bit off for whatever reason.

from react-photo-gallery.

marko911 avatar marko911 commented on June 3, 2024

@neptunian You can close this. I've resolved the issue using the new version and a custom image component. There are no issues with your code , thanks for support :)

from react-photo-gallery.

neptunian avatar neptunian commented on June 3, 2024

okay cool, well i published a new release anyway getting rid of some decimals that might have helped :)

from react-photo-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.