Giter Site home page Giter Site logo

Comments (5)

yuche avatar yuche commented on May 5, 2024 1

Thanks for the reproduce. It's a really nice that you can help us on the weekend. ❤️

from nerv.

yuche avatar yuche commented on May 5, 2024

See https://codesandbox.io/s/j2wym3n6w5 for Nerv behavior.
I guess Nerv can still access to the dom on componentWillUnmount function.

But still, there is bug in Top level API render, Nerv can just return null when first argument is null.
Thanks for point that out.

from nerv.

Havunen avatar Havunen commented on May 5, 2024

My point was that when doing keyed algo you remove DOM first, then call the callbacks. Ok I create full reproduce wait a sec.

from nerv.

Havunen avatar Havunen commented on May 5, 2024

https://codesandbox.io/s/3x29y3040m
edit: there is something else too ... I create another fiddle

another where it fails: https://codesandbox.io/s/5xpp5q4lyn

from nerv.

yuche avatar yuche commented on May 5, 2024

There is serval tests for this issue.

from nerv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.