Comments (3)
This library was made very quickly for my project, it still works there. I want to say that there was no goal to make a library. I realized that it might be useful to others, so I made it public. This means that I wrote the code a long time ago and there may be inaccuracies. Just make your code work, you can rewrite my watcher if needed
from action-cable-swift.
I'll be glad to accept your pull request, but please make the reconnect parameter data type enum instead of boolean. Let the enum contain three cases: none, standard, and your reconnect case
from action-cable-swift.
will do.
Before I get stuck in - could you explain a bit around the locking in PingWatcher ?
I understand the locking around finish
- this is accessed from the public isFinish()
function, and also from the watcher thread.
Other variables like lastTimePoint
seem to be only accessed from the watcher thread (and are private).
Is this just a case of being overly cautious, or am I missing some subtlety?
from action-cable-swift.
Related Issues (11)
- addOnMessage never gets called with starscream HOT 1
- Priority inversion warning HOT 1
- Any chance of a new release with the ping / channel name fix? HOT 4
- Channel not being subscribed HOT 1
- Connection issue in actioncable HOT 15
- onPing / onPong never called? HOT 3
- Update for use with URLSessionWebSocketTask HOT 1
- Leaked connections when trying to connect to a high latency server HOT 7
- The `send message` action is not working. HOT 2
- addOnMessage Calls multiple times for a single broadcast HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-cable-swift.