Giter Site home page Giter Site logo

Comments (3)

nerzh avatar nerzh commented on May 29, 2024 1

This library was made very quickly for my project, it still works there. I want to say that there was no goal to make a library. I realized that it might be useful to others, so I made it public. This means that I wrote the code a long time ago and there may be inaccuracies. Just make your code work, you can rewrite my watcher if needed

from action-cable-swift.

nerzh avatar nerzh commented on May 29, 2024

I'll be glad to accept your pull request, but please make the reconnect parameter data type enum instead of boolean. Let the enum contain three cases: none, standard, and your reconnect case

from action-cable-swift.

ConfusedVorlon avatar ConfusedVorlon commented on May 29, 2024

will do.

Before I get stuck in - could you explain a bit around the locking in PingWatcher ?

I understand the locking around finish - this is accessed from the public isFinish() function, and also from the watcher thread.

Other variables like lastTimePoint seem to be only accessed from the watcher thread (and are private).

Is this just a case of being overly cautious, or am I missing some subtlety?

from action-cable-swift.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.