TXmlReader.ParseComment throws parser error for valid XML comments

[tschroff]

TXmlReader.ParseComment throws parser error for valid XML comments

[tschroff]

I added the following test to expose this issue.

procedure TTestXmlReader.TestIssue11;
begin
  var Doc := TXmlDocument.Create;
  Doc.Parse('<foo><!--bar> </bar--></foo>');
  Doc.Parse('<foo><!-- >>>This is a comment<<< --></foo>');
  Doc.Parse('<foo><!-- This is a comment<<< --></foo>');
  Assert.Pass('Valid comments should pass.');
end;

The test passes with the suggested changes given in my previous comment.

However it seems that TTestXmlReader.TestParseError_InvalidCommentSuffix needs to become TTestXmlReader.TestParseError_UnclosedComment then, expecting a RS_XML_UNEXPECTED_EOF (or a new RS_XML_UNCLOSED_COMMENT) error.

procedure TTestXmlReader.TestParseError_UnclosedComment;
begin
  ExpectParseError('<foo><!--</foo>', RS_XML_UNEXPECTED_EOF, 1, 6);
  ExpectParseError('<foo><!--></foo>', RS_XML_UNEXPECTED_EOF, 1, 6);
  ExpectParseError('<foo><!---></foo>', RS_XML_UNEXPECTED_EOF, 1, 6);
  ExpectParseError('<foo><!--bar-></foo>', RS_XML_UNEXPECTED_EOF, 1, 6);
end;

But I think that would be reasonable.

[neslib]

@tschroff Thank you for contributing a fix for this issue. It is much appreciated!
I have merged #12