Giter Site home page Giter Site logo

Comments (4)

nesquena avatar nesquena commented on July 28, 2024 1

Yes if you finish and one or two others can run and give a thumbs up we are happy to merge this. Also it’d be great if you could add a section in the readme.

  1. Pick the simplest worker to add tests for first
  2. Yep I think that makes sense

I think you are on the right track but I’ll take another pass through later.

from backburner.

nesquena avatar nesquena commented on July 28, 2024

Yeah I think you are right, would be great for this to be configurable per queue. Thanks for the suggestion!

from backburner.

boncey avatar boncey commented on July 28, 2024

I'm having a crack at implementing this.
I'd welcome any feedback on my first commit.

The parts I'm unsure about are twofold.

  1. how to best test the work_one_job method.
    It seems to only be tested from each worker and I'm not sure which worker to test with.

  2. There's a partial implementation of per-queue retry_limit but only for certain workers.
    I guess this would behave the same as the per-queue max_job_retries that would become part of my MR.
    Is that likely to be an issue? I don't really want to touch the individual workers if I can help it.

Any feedback welcome.
Am I on the right track?
Is this MR likely to be accepted?

Thanks.
Darren.

from backburner.

boncey avatar boncey commented on July 28, 2024

⬆️ PR raised.
Comments welcome!

from backburner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.