I need JSONP callbacks support

[nesquena]

I need JSONP callbacks support

[nesquena]

Oh that's an interesting use case I hadn't thought of. Using RABL to generate a callback for jsonp. What do you imagine the syntax would look like in the template? Shouldn't be hard to add as far as I can tell. Basically just needs to check the option in the 'to_json' method.

[canavese]

It could just automatically wrap response if a 'callback' parameter is passed in the HTTP request (since that's standard). Disabling/enabling the functionality could be controlled with a global configuration.

[nesquena]

ok that would definately make it simple. Global configuration plus look at the callback in request parameters?

@sumskyi would that work for you?

[sumskyi]

yep, exactly. thanks!

[nesquena]

Alright I like it, maybe add global configuration for JSON root nodes as well.... I.E

Rabl.configure do |r|
  r.include_json_root = false
  r.include_callbacks = true
end

and then if the request has:

http://....?callback=foo

Will be wrapped with:

foo({...})

in output. Will hopefully be able to get to this soon.

[nesquena]

@sumskyi @canavese I have added full JSONP callback support to the git repo. Check the README for more details on configuration. Can you guys both try this from the repo directly. If it works without issue, I will push a new gem version. Commits here and here

Also support for supressing json root node. Configuration with:

# config/initializers/rabl_init.rb
Rabl.configure do |config|
  config.include_json_root = false
  config.enable_json_callbacks = true
end

[sumskyi]

Hi!

It works well.

Thank you!

[canavese]

Thanks for doing this so quickly. @sumskyi are both working on the same project, so we're both happy now :-)

[ami7ava]

Shouldn't it set the content-type as application/javascript since the content being returned is a javascript function?

[gcirne]

How about enabling callbacks for other formats? Specifically I'm interested in callbacks for MessagePack.

[fuzzyalej]

thanks for thisIt seems that having a good architecture makes changes nice and easy 👍

[vkhang55]

👍