Giter Site home page Giter Site logo

Comments (9)

SteelAlloy avatar SteelAlloy commented on August 20, 2024 3

I completely agree
After that it would also be a good idea to replace all occurrences of the word package by module in the internal code

from nest.land.

VienDinhCom avatar VienDinhCom commented on August 20, 2024 3

Use the term "module" instead of "library" or "package".

For clarity and consistency avoid the terms "library" and "package". Instead use "module" to refer to a single JS or TS file and also to refer to a directory of TS/JS code.

https://deno.land/[email protected]/contributing/style_guide#use-the-term-quotmodulequot-instead-of-quotlibraryquot-or-quotpackagequot

I think we should use https://deno.land/std for Standard Library and https://deno.land/x for Third Party Modules just like the https://deno.land/.

from nest.land.

t8 avatar t8 commented on August 20, 2024 2

I like this idea. I would prefer not to have /x (just to avoid confusion between x.nest.land and nest.land/x) unless we can get something working like how deno.land/x does it...

Though, I think @maximousblk has looked into this before, and it may be more effort than I think.

Regardless, @martonlederer's idea of a redirect from the current references would be absolutely critical.

from nest.land.

maximousblk avatar maximousblk commented on August 20, 2024 2

yes we can set the routes in the vercel.json file but that won't let us dynamically serve the website and raw module based on the request.

from nest.land.

maximousblk avatar maximousblk commented on August 20, 2024 1

it can also be done with vercel functions. I couldn't implement it in a simple way earlier because the URLs for the raw and web versions were way different. It won't take much effort if the routes work the same way on the web and in deno

what we have now:

  • URL for web: https://nest.land/package/eggs/files/mod.ts
  • URL for deno: https://x.nest.land/[email protected]/mod.ts
    note:
    the website is client side rendered so increases complexity when requesting a specific version.
    also, the current website supports linking to a specific version using a ...?v=0.2.3 query, but that doesn't work for the /files route. (bug?)

what we need:

then we can create a serverless function to forward the requests to the right place and deploy that to https://nest.land/...

you can boil all of that down to "the site is inconsistent"

from nest.land.

t8 avatar t8 commented on August 20, 2024 1

Hi @Maxvien! Thanks for the input.

This was our original plan for the system, however, we encountered some technical issues with that. Because our API is completely separate from the site, we had to put x on its own subdomain.

I wouldn't be against investigating a solution to allow for the /x and /std routes on Nest.land, but I personally do not know of a way around this issue. Note: We'd like to keep our Vercel sponsorship, as our site development/deployment workflow is massively simplified this way.

from nest.land.

martonlederer avatar martonlederer commented on August 20, 2024

We could also add a simple redirect for /package/:pkgname. Luckily we don't have it in the actual registry URLs

from nest.land.

martonlederer avatar martonlederer commented on August 20, 2024

It can be done with cloudflare workers. We should talk about this too in our meeting

from nest.land.

jasonappah avatar jasonappah commented on August 20, 2024

I wouldn't be against investigating a solution to allow for the /x and /std routes on Nest.land, but I personally do not know of a way around this issue. Note: We'd like to keep our Vercel sponsorship, as our site development/deployment workflow is massively simplified this way.

If I'm understanding this correctly, we should be able to get away with setting up routes in the vercel.json file. See here for more info.

Basically at the root of the repo we would create the vercel.json file, and add something like this:

{
  "routes": [
    { "source": "/x/(.*)", "destination": "https://x.nest.land/$1" },
    { "source": "/std/(?<ver>[^/]+)/(.*)", "destination": "https://x.nest.land/std@$ver\$STD_VERSION/$1" }
  ]
}

from nest.land.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.