Comments (3)
With toPromise() being deprecated, we are left with an Observable - this is quite a big API change!
According to RxJS migration guide, you should be able to replace toPromise()
with the lastValueFrom
.
Prev:
this.httpService.get(serviceUrl).toPromise();
Current:
lastValueFrom(this.httpService.get(serviceUrl))
That's a pretty simple change
from axios.
Shouldn't the migration guide be updated?
And I can't help the feeling that this conclusion isn't great for developers using NestJS - we are required to change many lines of code and add imports directly from RxJS - just to get what seems to be the sensible API.
It also means this module diverges from the NestJS API, which states:
The above code is fully valid. Furthermore, Nest route handlers are even more powerful by being able to return RxJS observable streams. Nest will automatically subscribe to the source underneath and take the last emitted value (once the stream is completed).
So this is the case for NestJS, but not @nestjs/axios
.
from axios.
Shouldn't the migration guide be updated?
toPromise()
is deprecated, not removed. Also, this change comes from the RxJS so you should navigate to the RxJS migration guide for more information on the breaking changes they've made.
The above code is fully valid. Furthermore, Nest route handlers are even more powerful by being able to return RxJS observable streams. Nest will automatically subscribe to the source underneath and take the last emitted value (once the stream is completed).
This statement is still correct.
Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.
from axios.
Related Issues (20)
- Add ability to add types for data object in HttpService HOT 1
- Add new Multipart Bodies methods from Axios HOT 1
- Use class-transformer for json deserialization HOT 1
- Update version Axios for 1.6.0 version HOT 2
- Support for axios interceptors HOT 1
- Error: self signed certificate in certificate chain HOT 2
- Upgrade to Axios major 1.x HOT 2
- Upgrade axios to next major release HOT 1
- axios has a bug that was resolved in axios 1.2.0 HOT 3
- Allow the HttpModule to register headers with the HeadersDefaults type HOT 1
- Duplicated interceptors HOT 4
- Axios needs to be updated to 1.2.x HOT 1
- Make it easier to use axios types HOT 5
- Current axios version used 1.2.1 has Bug with Brotli, bump needed to 1.2.2 HOT 1
- Support for Axios 1.3.0 HOT 2
- Typescript error in dist/http.service.d.ts in "@nestjs/axios": "^2.0.0" HOT 5
- Nest v8 Support - Update of axios dependency to at least v1.2.2 HOT 1
- Сonfigurable axios instance with retrays and interceptors. HOT 1
- this library does not support Nestjs 10.0.0 HOT 1
- Provide optional payload in delete request HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axios.