Giter Site home page Giter Site logo

Comments (2)

drdreo avatar drdreo commented on July 28, 2024 1

I also ran into this. But after upgrading from 10.2.10 --> @nestjs/[email protected] and @nestjs/[email protected].
In thisprovided repo the tests fail , there is also a working branch.

from cache-manager.

quangtran88 avatar quangtran88 commented on July 28, 2024 1

While testing with the following versions:

"@nestjs/cache-manager": "2.2.2",
"@nestjs/common": "^10.3.10",
"@nestjs/core": "^10.3.10"

the issue seems resolved, but a strange bug occurs when CacheModule is registered with the same configuration. It shares the same cache store even if it is imported by different modules. Here is the reproduction: https://codesandbox.io/p/devbox/nestjs-cache-register-bug-2snp4k?file=%2Fsrc%2Fapp.spec.ts

After investigation, I realized that the useFactory function provided by CACHE_MANAGER is only called when the options parameter is registered differently.

useFactory: async (options: CacheManagerOptions) => {

Is there any caching mechanism applied when initializing a dynamic provider here related to ConfigurableModuleBuilder? If so, I think we can fix this issue by generating a unique ID each time the CacheModule is registered, like the following:

static register<StoreConfig extends Record<any, any> = Record<string, any>>(
    options: CacheModuleOptions<StoreConfig> = {} as any,
  ): DynamicModule {
    return {
      global: options.isGlobal,
      ...super.register({ ...options, id: <UNIQUE_ID> }),
    };
  }

from cache-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.