Giter Site home page Giter Site logo

Comments (2)

kamilmysliwiec avatar kamilmysliwiec commented on May 2, 2024

Would you like to create a PR for this issue :)?

from mongoose.

BorntraegerMarc avatar BorntraegerMarc commented on May 2, 2024

Done: #230

I added a PR to introduce typesafness without breaking changes.

But in my opinion we should refactor the forRoot method to not have the first param uri. And make the URI non-optional in the MongooseModuleOptions. Then we could safe this if statement. This would also have the advantage that the forRoot method and the MongooseModuleAsyncOptions have the same params. Which feels better for me.

This would introduce breaking changes so I didn't do it now with the current PR. But if you agree I can create a new issue & a new PR to implement these suggestions :)

from mongoose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.