Comments (6)
I started to work on @configuration
For now I have something like this:
Decorator:
import 'reflect-metadata';
import {ConfigurationMetadata} from '../../interfaces/configuration-metadata.interface';
import {isNil, isObject} from '../shared.utils';
import {FILE_METADATA, IN_MEMORY_METADATA, URL_METADATA} from '../../constants';
export const Configuration = (metadata?: ConfigurationMetadata): ClassDecorator => {
return isObject(metadata) ? ConfigurationFrom(metadata) : InMemoryConfiguration();
};
const InMemoryConfiguration = (): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(IN_MEMORY_METADATA, true, target);
}
};
const ConfigurationFrom = (metadata: ConfigurationMetadata): ClassDecorator => {
if (!isNil(metadata.file))
return FileConfiguration(metadata.file);
else if (!isNil(metadata.url))
return RemoteConfiguration(metadata.url);
};
const FileConfiguration = (filename: string): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(FILE_METADATA, filename, target);
}
};
const RemoteConfiguration = (url: string): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(URL_METADATA, url, target);
}
};
Helper classes:
export interface IConfiguration {
getProperty(name: string): string;
}
export abstract class AbstractConfiguration implements IConfiguration {
constructor(protected properties: {[key: string]: string} = {}) {}
public getProperty(name: string): string {
return this.properties[name];
}
}
export abstract class AbstractInMemoryConfiguration extends AbstractConfiguration{
constructor() {
super();
this.declare();
}
protected abstract declare(): void;
}
And a use case:
class TestConfiguration extends AbstractInMemoryConfiguration {
protected declare(): void {
this.properties['KEY'] = 'VALUE';
}
}
Regarding the @configuration decorator I can declare it like this:
@Configuration()
class TestConfiguration extends AbstractInMemoryConfiguration { }
@Configuration(file: 'filename')
class TestConfiguration extends AbstractFileConfiguration { }
@Configuration(url: 'http://domain/path')
class TestConfiguration extends AbstractRemoteConfiguration { }
Does it seem to be good for you guys ?
from nest.
Are you sure we really need the abstraction layer over configuration stuff? I think now it's easy to fetch the remote configuration / load config using fs package just before creating the Nest instance. If the configuration affects components and should be a part of the DI container - just use async components. What @thomrick proposed looks really good, but I'm trying to keep in mind that learning curve is already big enough 😃
from nest.
Hi @thomrick,
Thank you so much for the invested time, but I just don't want to exaggerate. Maybe in the future, but not now 🙂 Kamil
from nest.
@kamilmysliwiec could you leave it open? It's very nice feature.
from nest.
You convinced me.
from nest.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from nest.
Related Issues (20)
- Allow readonly arrays as providers, imports, etc. HOT 3
- Validation fails in RPC context for MqttContext HOT 6
- Only the last APP_FILTER providers works HOT 4
- dependency injection does not work. HOT 3
- gRPC Streaming endpoints that throw errors crash the main process HOT 2
- Injectable instances can have references to Request objects and can hold it forewer in request scope
- Middleware consumer have a text error HOT 3
- Extra options are set only to default values when using `registerAsync` HOT 2
- Can we have a template resource for graphql + rest together? HOT 5
- Connection Error in Service during Startup HOT 2
- Wrong type (as in #12264) HOT 3
- Nest CLI generates the wrong package.json file HOT 8
- Watch mode is broken HOT 1
- Hyphens in parameters silently fail HOT 4
- Improve documentation on @Injectable() HOT 2
- Log is not auto-flushed on error during initialization HOT 1
- Middleware not executed when using `exclude` in `setGlobalPrefix` HOT 1
- The use of SetMetadata custom decorators does not take effect HOT 13
- NestJS HttpException class returns success status when status is undefined HOT 4
- NestJs DI `useFactory` ignores property dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.