java.net.Uri doesn't handle { } characters

[net-a-porter]

java.net.Uri doesn't handle { } characters

[GentlemanHal]

Probably worth checking if there are any other 'dodgy' but not illegal characters that should also be escaped?

[theon]

Agreed. I've added curly braces in be638f2 and some other characters such as new lines in a8a64d3 . This change should be available in the 0.3-SNAPSHOT.

I agree it makes sense to try and play nice with java.net.URI, so I'll leave this ticket open, until I have time to look through that code to work out exactly all the characters need to be encoded.

[GentlemanHal]

Ah cool, thanks for looking into this.

As mentioned before we don't really want to depend on a snapshot, so if you let me know when you push a new release that would be awesome.

[theon]

Hi,

I've pushed version 0.3 out, so you can use that now. It should have the fix for {``} characters.

I still haven't got round to investigating all the characters that need to be encoded to play well with java.net.URI, so I will leave this ticket open for now.

[theon]

I got lost in the character class masks in java.net.URI trying to find exactly which characters must be encoded to play nice with java.net.URI, so instead thought it would be easier to bute force it with this code. scala-uri encodes anything not in the ASCII range, so I only checked ASCII chars:

var ok = List[Char]()
var notOk = List[Char]()

(0 until 128).foreach(i => {
  try {
    URI.create(i.toChar.toString)
    ok = i.toChar :: ok
  } catch {
    case e:Exception => {
      notOk = i.toChar :: notOk
    }
  }
})

println("OK:" + ok.mkString)
println("NOT OK:" + notOk.mkString)

Results are:

OK:~zyxwvutsrqponmlkjihgfedcba_ZYXWVUTSRQPONMLKJIHGFEDCBA@?=;9876543210/.-,+*)('&$#!
NOT OK:}|{`^]\[><:%"

\ was the only NOT OK character that scala-uri wasn't encoding, so added here: 01c00bb

[GentlemanHal]

Awesome, thanks for fixing this.

Usual question, can you let me know when this is added to an official release? :)

[theon]

Sorry for the delay. I've now published a 0.3.3 release which includes this.