Comments (1)
The user experience is quite tricky here because the permissible name length for regular Argo workflows is greater than for Cron workflows.
So,
- The user creates a flow and run
python flow.py argo-workflows create
. This creates the workflow template without any error - The user is able to run this flow either via
python flow.py argo-wokflows trigger
or via the Argo UI and it works just fine. - The user then adds
@schedule
decorator and runpython argo-workflows create
. This creates the workflow template and the CronWorkflow. No errors. - But if the name > 52 characters, the actual flows don't run on the cron schedule. The only way to identify the problem is to look at the argo-workflows-controller logs as shown above and see the error.
What's needed here is the following.
When a user creates a flow with @schedule
:
- Construct the name as it is done today. If the name length < 52 chars, create the template, cronworkflow.
- If the name length > 52 chars:
- check if there is a previously created cronworkflow object. If so, delete it (since it wouldn't be running anyway).
- create a name such that it is < 52 characters. e.g. take all characters > 46 and construct a 6 byte has to fit into 52 chars
- Create the new cronworkflow
/cc @savingoyal @saikonen
from metaflow.
Related Issues (20)
- Argo Events: trigger sensors are not deleted
- Allow option to set labels on pods using `kubernetes` decorator HOT 1
- Bug: Runner API doesn't pass parameters to flows as expected HOT 4
- Log failure reason in slack alerts for deployed flow failures
- Display full trigger event payload in metaflow ui HOT 1
- ArgoEvents.publish attempts to make requests even when url is None HOT 1
- @conda/@pypi appears to remove CUDA instructions for GPU HOT 4
- support json event payload for local testing through --trigger
- Caching steps HOT 1
- Silent failure to trigger Argo Workflow from CLI HOT 2
- ServiceException (code 500): run_number is out of range for type integer, when running with local metadata HOT 3
- An error occurred with Micromamba while creating a workflow containing @pypi HOT 2
- micromamba complain from @pypi_base about package incompatibility in intel macos HOT 5
- argo-workflows create --only-json doesn't export sensor configuration
- Argo Workflows Overrides Image in @kubernetes annotation. HOT 2
- Errors resuming a workflow HOT 2
- S3 External Client Option Ignored by s3op
- metaflow failed to resume a flow HOT 1
- `MetaflowData.__getattr__` should raise `AttributeError` on failure
- Request: Allow shadowing in metaflow_extensions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metaflow.