Global Methods dont work with out type

[becjit]

Global Methods dont work with out type

[petrnymsa]

Agree, that we can extend "custom" behavior on Field level in way that

• If provided function has any argument - it has to be "SOURCE" object argument - e.g for custom mapping from source (current behavior
• If provided function has zero arguments - call it as is. new behavior. This would allow OP's request.

[petrnymsa]

@becjit Can you try out this solution from #169 ?

In pubspec.yaml you can change auto_mappr dependency from

auto_mappr: ^x.xx

to

auto_mappr:
    git:
      url: https://github.com/netglade/auto_mappr
      path: packages/auto_mappr
      ref: feat/168-extends-custom-mapping

Let us know! Thanks 🚀

[tenhobi]

Hi @becjit, could you please elaborate more?

In this case static methods without any Source model argument is required, but looks like converters are not allowed without the source model

So you would want a type converter that does not have a source? How would that work?

---

The correct/current behavior is like this and I think it makes sense, no? For you to map/convert, you always need the source to produce the target. How would that work otherwise -- matching which converter to use, for example?

@AutoMappr(
  [
    MapType<UserDto, User>(
      // MapType specific
      converters: [
        TypeConverter<String, DateTime>()
      ],
    ),
  ],
  converters: [
    // or globally here
  ],
)
class Mappr extends $Mappr {
  static DateTime stringToDateTime(String source) {
    // ...
  }
}

// https://github.com/netglade/auto_mappr#type-converters

[becjit]

Sure thing!
Let's say in the target I have a field with DateTime, and source does not have any corresponding column.
So I really dont need the source model to generate value for the target; a simple DateTime.now() would do.

Now let's say I have multiple models with similar requirements. Currently I am copy pasting the same code with separate SourceModel as across mappers

For example

@AutoMappr([
  MapType<UserDto, User>(
    fields: [

      Field('created', custom: Utility.mapDateTime), // Global method.

    ],
  ),
])
class Mappr extends $Mappr {

}

and

@AutoMappr([
  MapType<OtherDto, Other>(
    fields: [

      Field('created', custom: Utility.mapDateTime), // Global method.

    ],
  ),
])
class OtherMappr extends $Mappr {

}

class Utility {
 static DateTime mapDateTime(/* not needed */String source) {
    return DateTime.now();
  }
}

instead of that I could just have one global method mapDateTime and refer that in the converter. Do let me know if I am missing something obvious.
And thank you for the getting back quickly

[tenhobi]

I see. Well, since TypeConverter converts from source and target, that's not the right thing to do anyway.

We could however potentially extend the behavior of custom in Field, since even now (I think :D) you can use either a function TARGET something(SOURCE) or a TARGET constant. And I think we could distinguish between 0 and 1 argument there based on the function you pass in. 🤔

Aka then you could do this

@AutoMappr([
  MapType<OtherDto, Other>(
    fields: [
      Field('something', custom: Utility.mapStringToInt), // internally will use Utility.mapStringToInt(model)
      Field('created', custom: Utility.mapDateTime), // internally will use Utility.mapDateTime()
    ],
  ),
])
class OtherMappr extends $Mappr {
  const OtherMappr();
}

class Utility {
  static DateTime mapDateTime() {
    return DateTime.now();
  }
  static String mapIntToString(String value) {
    return '$value';
  }
}

Thoughts, @petrnymsa ?

---

That being said, this is potentially an easy upgrade, do you want to take this and do a PR for that? Otherwise we don't probably have time any time soon for this -- maybe in January or February.

What is needed to be done:

• https://github.com/netglade/auto_mappr/blob/main/packages/auto_mappr/lib/src/extensions/dart_object_extension.dart#L19C52-L25 modify this (detect 0 vs 1 arguments)
• add some tests
• update docs

[petrnymsa]

I am cooking some ad-hoc solution right now 🔥

[becjit]

Sure thing. Thanks a lot. Will get back to you soon

…

On Wed, Dec 13, 2023 at 11:42 PM Petr Nymsa ***@***.***> wrote: @becjit <https://github.com/becjit> Can you try out this solution from #169 <#169> ? In pubspec.yaml you can change auto_mappr dependency from auto_mappr: ^x.xx to auto_mappr: git: url: https://github.com/netglade/auto_mappr path: packages/auto_mappr ref: feat/168-extends-custom-mapping Let us know! Thanks 🚀 — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ4MLU4E4JJP3S2VZR47J3YJHVXLAVCNFSM6AAAAABASPY2LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGQ3TIOJRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tenhobi]

Hey @becjit, did you have time to validate whether this change helps your case? :)

[becjit]

Yep I just smoke tested. Seems to work fine. Will do some more testing and will let you know

…

On Tue, 2 Jan 2024 at 5:31 PM, Honza Bittner ***@***.***> wrote: Hey @becjit <https://github.com/becjit>, did you have time to validate whether this change helps your case? :) — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ4MLVL5B2GUFR3QK5RNSTYMPZKNAVCNFSM6AAAAABASPY2LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTHE2DAOJRG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[petrnymsa]

Fix available in 2.3.0 🎉