Comments (1)
Yes, that looks wrong, too. Fixed it, thanks.
On the result code: that's intentional, yes. NBD_CMD_TRIM really is a hint to the server that the client doesn't care anymore about the contents of a range in the file. It is not an initializer; only NBD_CMD_WRITE is. The original implementation of NBD_CMD_TRIM would just read the command, acknowledge it, and do nothing.
As such, any client which expects any range in a file that has been part of an NBD_CMD_TRIM to be all zeroes, is buggy; this implies that returning an error on NBD_CMD_TRIM would be utterly meaningless, since a client shouldn't care about it anyway.
from nbd.
Related Issues (20)
- Syntax error in /etc/nbdtab when using ip as host
- NBD server unreliable when in debug mode (-d) HOT 1
- can't connect server to client
- A typo in the format string in error message in nbd-client.c HOT 1
- Integer Overflow in nbd-client.c:421
- Stack Overflow in nbd-client.c: 501 HOT 1
- client authorization is always successfull (return true) for v6-mapped IPV4 addresses.
- Sporadic build failure with parallel make due to implicit dependency in Makefile.am
- Crashes when giving HUP-signal to nbd-server HOT 2
- 3.24: test suite runs forever HOT 8
- How to configure a local Ubuntu system to boot from NBD server hosting a multiple partition(e.g. GPT) image HOT 3
- server fails with glib2 2.76.0 HOT 22
- support windows client or server version HOT 1
- nbd-3.25 compile failure in gznbd HOT 2
- Extremely low performance with 20 simultaneous clients and 9Gb squashfs image HOT 3
- Performance optimization HOT 3
- Feature request: nbd-server serves multiple (autogenerated) files in directory hierarchy HOT 1
- default port become 0 after updating to 3.26.1 HOT 1
- NBD export fail "nbd0: truncated" to mount with block size other than 512 HOT 1
- compiler warning: warning: 'daemon' is deprecated: first deprecated in macOS 10.5 - Use posix_spawn APIs instead. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbd.