Giter Site home page Giter Site logo

Comments (6)

aquette avatar aquette commented on May 12, 2024

Thanks for not having closed this bug Charles.
I finally had time to consider it and indeed, it doesn't make sense in at least 1 case:
text based browser (such as w3m), which I still have a close look at, for accessibility consideration.
In this specific case, we translate the "stars level" into numbers.
Hence, displaying the legend is not desirable here, without transformation of stars into numbers too.

hcl-w3m

there is a mix of html specific syntax ("noscript"), jscript and css that don't get.
@zykh & @JeanPerriault: would you please be able to help?

from nut.

zykh avatar zykh commented on May 12, 2024

js + css + html:
zykh@c8b1c03
-> https://drive.google.com/file/d/0BxWv_9cok7BKc3dieGNKWTlQejA/edit?usp=sharing

css + html:
zykh@e7b7b77
-> https://drive.google.com/file/d/0BxWv_9cok7BKSGhQUFFhYTNsdUk/edit?usp=sharing

is one of them ok?

from nut.

aquette avatar aquette commented on May 12, 2024

Impressive reactivity Dan!
I would go for the 2nd, keeping stars in legend for graphic browsers, and numbers for the text ones.
Thanks!

from nut.

clepple avatar clepple commented on May 12, 2024

One thing I was wondering is whether it would make more sense for the support level dropdown to be ">=", i.e. "this many stars, or better". Would either of these methods make that style of filter easier to implement?

We can always address that later. I'm fine with either commit mentioned above. Want me to merge the 2nd one?

from nut.

zykh avatar zykh commented on May 12, 2024

Done on the css one.

Is it ok for you if I move nut_jquery.js to tabs instead of the 2 space indent and improve a little readability?

from nut.

clepple avatar clepple commented on May 12, 2024

Is it ok for you if I move nut_jquery.js to tabs instead of the 2 space indent and improve a little readability?

Sure, sounds good.

from nut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.