Comments (7)
Also I opened up an issue so we can start working through style guide for the application styleguide as well. #37
from holtzman.
Makes sense to me 👍
from holtzman.
One change that will be needed is the naming of the helper. Spacebars doesn't allow you to have .
in a helper name and I don't think it is worth amending that for this helper.
Proposed name: {{pathForState 'profile.signIn'}}
would: {{state 'profile.signIn'}}
be clear enough?
Thoughts?
from holtzman.
I know I am Mr. Verbose, but maybe "cardState" would be more clear than just "state"
from holtzman.
@BenWiley I'm good with that. {{state ' '}} could get confusing when outputting actual states (like SC, NC, etc). and cardState seems better
from holtzman.
I like "cardState". Is "pathForState" more Meteor conventional though?
from holtzman.
@johnthepink pathForState probably gives a better idea of what the output will be (a path) and its inline with pathFor for Iron router and flow router. Its ugly but is closer to what the community has adopted. 👍 for clarity
from holtzman.
Related Issues (20)
- Update NewSpring logo for alerts. HOT 1
- Double tap to like HOT 1
- Incorrect copy in Group Finder HOT 1
- Show grayed out picture for no group picture HOT 1
- Dividing line should be 1px HOT 1
- Sign-in error stuck at the bottom of the screen HOT 1
- NewSpring logo cut off HOT 1
- Gray out "Enter" when no password is present HOT 1
- Cannot go back when entering a new payment HOT 1
- Add "Give Feedback" button HOT 1
- Pre-log user in to Group leader toolbox HOT 1
- Top entries switch places after refreshing HOT 1
- "View leader toolbox" button still grayed after leaving toolbox HOT 1
- Modal isn't reset from prompt status HOT 1
- Remove "Looking for another group" section from fuse groups HOT 1
- "Give as Guest" Disabled when changing amounts
- Change toolbox button language HOT 4
- Pre-fill feedback subject line HOT 1
- my.newspring.cc in production and beta dont match app HOT 2
- Crosswalk Build Issues for Android HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holtzman.