Giter Site home page Giter Site logo

Comments (10)

cbetta avatar cbetta commented on July 30, 2024

Makes sense.

from nexmo-cli.

leggetter avatar leggetter commented on July 30, 2024

I suggest we modify the price:country non verbose response to be a range
of the lowest and highest values returned by the API so for GB it should
show 0.0314 - 0.0333 EUR

"response" or do we mean "output"?

On Mon, 20 Jun 2016, 10:19 Cristiano Betta, [email protected]
wrote:

Makes sense.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#57 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAUCr7lVELWsjz2KSS4oDYQfW5n-CtA4ks5qNlsagaJpZM4I5eKe
.

from nexmo-cli.

sammachin avatar sammachin commented on July 30, 2024

whats the difference between response and output?

On Mon, Jun 20, 2016 at 10:23 AM Phil Leggetter [email protected]
wrote:

I suggest we modify the price:country non verbose response to be a range
of the lowest and highest values returned by the API so for GB it should
show 0.0314 - 0.0333 EUR

"response" or do we mean "output"?

On Mon, 20 Jun 2016, 10:19 Cristiano Betta, [email protected]
wrote:

Makes sense.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#57 (comment),
or mute
the thread
<
https://github.com/notifications/unsubscribe/AAUCr7lVELWsjz2KSS4oDYQfW5n-CtA4ks5qNlsagaJpZM4I5eKe

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#57 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AALc_V_a2SRv1CRFGl743UJN6WuuUG5dks5qNlwagaJpZM4I5eKe
.

from nexmo-cli.

cbetta avatar cbetta commented on July 30, 2024

BTW when I designed the CLI the goal for the non verbose output has always been to be predictable so that it can be used in a Unix environment to be piped into other commands. For that reason 0.0314 EUR is a lot more useful than a range. Are we sure we're happy to drop this?

from nexmo-cli.

leggetter avatar leggetter commented on July 30, 2024

whats the difference between response and output?

In the context of the nexmo-cli the response could be thought of as the response from the API that is being called or the output from the command. If we mean the latter then output is clearer.

I suggest we modify the price:country non verbose response to be a range of the lowest and highest values returned by the API so for GB it should show 0.0314 - 0.0333 EUR

For purposes of my education, how is the range determined? Does this required two underlying API queries?

BTW when I designed the CLI the goal for the non verbose output has always been to be predictable so that it can be used in a Unix environment to be piped into other commands. For that reason 0.0314 EUR is a lot more useful than a range. Are we sure we're happy to drop this?

I guess it depends on whether "may mislead users causing additional support overhead" can be justified. Are there examples of this already? Could we instead just use the maximum possible cost/value?

from nexmo-cli.

sammachin avatar sammachin commented on July 30, 2024

fair point, To me the response from the Dev API and/or our pricing model, the perfect option would be to clean up the prices but I didn't get anywhere with that.

Just returning the max price might be another option, especially as there's usually very little variation, again we'd need to check if nay countries have a very high outlying price.

from nexmo-cli.

cbetta avatar cbetta commented on July 30, 2024

It would remain 1 API call.

from nexmo-cli.

sammachin avatar sammachin commented on July 30, 2024

Out of interest the website just shows the higher price for "All Networks" which adds weight to the case for showing the max, at least we would be consistent with the web site.
screen shot 2016-06-20 at 10 48 05

from nexmo-cli.

cbetta avatar cbetta commented on July 30, 2024

So maybe thats a better idea?

from nexmo-cli.

leggetter avatar leggetter commented on July 30, 2024

+1 for showing MAX price

from nexmo-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.