Comments (4)
Please create a branch with the proposed change and link to it here so that we can compare and contrast the two approaches.
from ic.
In gonzaponte/citiesargs you can find a draft of the code for this issue (it is a couple of commits behind nextic/master, but I will rebase). I have made two things:
- Remove from base classes (SensorResponseCity, CalibratedCity, etc.) all arguments belonging to the classes they inherit from, keeping only those owned by the class.
- Remove from implementation classes (Diomira, Irene, etc.) all arguments belonging to the base classes. This means that some explicit constructors which only job was to call the superclass constructor are not needed, so they have been also removed. In the remaining ones, the call is reduced to a single line.
I have done this in separate commits so it can be easily reverted.
from ic.
@jjgomezcadenas You and I should look at this with peras and make a decision.
from ic.
Agreed, next week!
from ic.
Related Issues (20)
- Merging MC files HOT 13
- Gaussian noise for hypathia PMTs HOT 1
- XYpeak in Penthesilea
- Keep file information when loading many files HOT 2
- Filter events where energy correction is not possible? HOT 4
- Rethinking post-penthesilea production HOT 11
- Generating MC timestamps HOT 1
- mark.feetest warning
- Travis changes HOT 4
- Get Event Numbers from MC files HOT 2
- Review skipped and xfail tests
- Singularity container for IC and Nix HOT 5
- Avoid shape mismatch in buffy with inconsistent sensor ids
- Buffy/detsim max_time and buffer_length
- Wrong dst loading in city sources HOT 3
- `make_tracks` does not use `contiguity` argument
- Generalize the waveform writer to store floats
- Fake energy in hypathia's PMT noise simulation HOT 3
- Standardize naming of groups and nodes in output files
- Add MC info in kdsts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ic.