Giter Site home page Giter Site logo

Cities init method arguments about ic HOT 4 CLOSED

next-exp avatar next-exp commented on July 19, 2024
Cities init method arguments

from ic.

Comments (4)

jacg avatar jacg commented on July 19, 2024

Please create a branch with the proposed change and link to it here so that we can compare and contrast the two approaches.

from ic.

gonzaponte avatar gonzaponte commented on July 19, 2024

In gonzaponte/citiesargs you can find a draft of the code for this issue (it is a couple of commits behind nextic/master, but I will rebase). I have made two things:

  • Remove from base classes (SensorResponseCity, CalibratedCity, etc.) all arguments belonging to the classes they inherit from, keeping only those owned by the class.
  • Remove from implementation classes (Diomira, Irene, etc.) all arguments belonging to the base classes. This means that some explicit constructors which only job was to call the superclass constructor are not needed, so they have been also removed. In the remaining ones, the call is reduced to a single line.

I have done this in separate commits so it can be easily reverted.

from ic.

jacg avatar jacg commented on July 19, 2024

@jjgomezcadenas You and I should look at this with peras and make a decision.

from ic.

jjgomezcadenas avatar jjgomezcadenas commented on July 19, 2024

Agreed, next week!

from ic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.