Only works on Nextcloud 13

[nextcloud]

Only works on Nextcloud 13

[tobiasKaminsky]

I setup a nc12 account on files app, and then started news app to use this account and I get "tobi" back as username:

Where do you see this account?
(Internally in files app all accounts are stored as loginname @ server base url)

[David-Development]

I saw it in the "account-chooser" dialog. The account was named: "@192.168.10.38" instead of "[email protected]". Maybe I need to run another test later today.. Thanks for testing!

[tobiasKaminsky]

First is NC13, second is NC12.

As NC12 will be outdated once NC14 is released and SSO will be in Files app 3.3.0 (expected in ~2 months), it would not be that bad if this is a NC13+ feature.

But if I remember correctly there was no big change from 12 to 13.

[David-Development]

Hm.. I think we need to have some kind of backwards support though. I think there are maaany users that are still using NC 9/10/11/12. And if we have the limitation, that we only support NC13+, other app developers will get into a lot of trouble if users start complaining about how it's not working anymore and that they have to upgrade their backend in order to use their news/notes app that they've been using for years now.

[tobiasKaminsky]

Can you test it again with NC12, as it is working for me?
With current approach (not generate new token), we can theoretically support back to 9. With token generation we would require the new login method, which is in NC12.

As I understand the purpose of this lib, SSO is only an addition, but should not replace the legacy login, or? (same like you have on your news app: plain login and SSO). With having it both in parallel it would be not that bad if this is a NC12+ feature.

[David-Development]

That is true, but it means "twice" the work for the developers. The intention behind building this app was to let the files app handle all the security / login stuff so that the developers can purely focus on writing their apps without worrying about the network connection. Right now the sso integration in the news app is a proof of concept, but I wanted to completely remove the legacy login in the long run and make the SSO mandatory :)

[tobiasKaminsky]

Can you retest this again @David-Development?
For me it does not happen.

If it is working with older NC, then you/3rd party apps indeed could remove the network stack

[tobiasKaminsky]

@David-Development what is the status here? :-)

[David-Development]

@tobiasKaminsky I guess we can just close it.. We'll see if anyone encounters any issues 😬