Comments (11)
I added Android SSO (and Android News) to the codacy checked repositories
Awesome!! Thank you 👍
Should I also add the codacy checks to the PRs like we do for the files app and the android library repositories?
I'm not sure if I get the question correctly. This repository (Android-SingleSignOn
) as well as the news-android
repository don't have open PR's anymore. It's already merged on master (in both repositories).
from android-singlesignon.
I'm not sure if I get the question correctly.
My question is if I should activate "codacy for PRs" for the repositories. If I do this will be a PR check run on every (future) PR which would block merges (except for forced, admin merges) if codacy detects any new issues caused by the PR in comparison to the master branch. (Like you see in the files app repo for the SSO branch/PR)
from android-singlesignon.
@David-Development I also invited you to the codacy admin team. This way you can always set issues to be ignored or customize the rules that get checked e.g. for pmd, checkstyle, etc. :)
from android-singlesignon.
Yes, I think we should enable this.
And, as dev speed slows down, also prevent pushing directly to master.
from android-singlesignon.
Yes, I think it's a good idea to keep code quality up! :) I'll try to fix some code-quality issues later today!
from android-singlesignon.
@tobiasKaminsky can you activate the post commit hook in codacy? I do not have any rights on the repos atm.
from android-singlesignon.
Should be done.
It may need to be enabled as required status after creating a PR.
Just ping me, if a PR is open and codacy is not fully working.
from android-singlesignon.
@tobiasKaminsky please also activate it for Android News client :) ❤️
from android-singlesignon.
@David-Development can you then please invite @nextcloud-android-bot and make him an admin in your repo?
from android-singlesignon.
@tobiasKaminsky to the nextcloud/news-android repo on GitHub? I don't have admin right there..
from android-singlesignon.
No problem, nextcloud-android-bot is added and codacy is now working 👍
from android-singlesignon.
Related Issues (20)
- Provide convenience class for OCS requests HOT 4
- Support .qa package id of the files app
- Convenience features for `NextcloudRequest.Builder`
- Handle `QueryParam` with key "`c`" HOT 4
- SEARCH HTTP method is not supported HOT 7
- Support Activity Result API HOT 3
- Rotation issues
- i18n: `Benötigt keine Übersetzung. Für Android wird nur die formelle Übersetzung verwendet (de_DE).` HOT 7
- If only dev app is installed SSO doesn't work HOT 8
- Break on minified app HOT 12
- Migrate to Material 3 theme HOT 1
- Option to create new token on `TokenMismatchException` HOT 3
- Availablity on Amazon store HOT 1
- Instantiating `Void` does no longer work with AGP 8 HOT 18
- Improve SSO error dialogs shown by 3rd-party-apps HOT 2
- Check `NetworkRequest#mDestroyed` before each network request? HOT 1
- Readme contains bad R8 advice HOT 1
- Reportedly not working when used within Samsung Knox HOT 1
- Possibility to get WebDAV-capable app password/token from SSO HOT 5
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-singlesignon.