Giter Site home page Giter Site logo

Comments (5)

David-Development avatar David-Development commented on September 23, 2024 1

@strugee Thank you :)

@tobiasKaminsky the problem is, that we don't support the dev version yet. As the package is different from (com.nextcloud.client), the sso library won't pick up its existence.

Is this something we should support? If yes, how do we handle it if both apps are installed and the user configured different accounts in each app? Or the same account?

Problematic snippets:

if (appInstalledOrNot(fragment.getContext(), "com.nextcloud.client")) {

https://github.com/nextcloud/Android-SingleSignOn/blob/82bbca0e8ff79eb0cf5690096d84f5c5a7def26a/src/main/java/com/nextcloud/android/sso/helper/VersionCheckHelper.java

from android-singlesignon.

tobiasKaminsky avatar tobiasKaminsky commented on September 23, 2024 1

Is this something we should support?

If that is not too much work, why not…

If yes, how do we handle it if both apps are installed and the user configured different accounts in each app? Or the same account?

When querying & displaying the accounts we then would need to check on both apps and should add (dev) to the dev version accounts.

Accounts from dev and stable app which point to the same user (e.g. [email protected]) should then be distinguished.

from android-singlesignon.

strugee avatar strugee commented on September 23, 2024 1

Closing since #63 got merged and 0.4.0 went out with (according to the GitHub release notes) support for this. If that's not right feel free to reopen! Thanks 👍

from android-singlesignon.

David-Development avatar David-Development commented on September 23, 2024

Thanks for the feedback. Yes, this is the right place. Indeed, this shouldn't happen.. It shouldn't matter if you have the dev version or the one from google play.

Couple of questions for you:

  • What Android Version are you on?
  • Did you compile the nextcloud dev version yourself?
  • What version of the nextcloud news app are you using?

from android-singlesignon.

strugee avatar strugee commented on September 23, 2024

I'm on LineageOS 15.1 (Android 8.1). Both apps are installed from F-Droid. News version is 0.9.9.25.

from android-singlesignon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.