Cannot use shared folder for notes anymore.

[SimeonEhrig]

Cannot use shared folder for notes anymore.

[SimeonEhrig]

Any response on this problem? Looks like a lot of people have the same problem and nobody knows, what the code should do, which causes the problem.

It is a little bit annoying, yesterday was a new release and there is still no response from a developer :-(
At the moment, this means I have to fix the bug locally from time to time :-(

[callmetango]

This is happening to me as well using the same setup as above. The bug was introduced in commit a5bec1a.

After commenting out the faulty code in the source code of the installed Notes App, everything works as expected again.

Unfortunately it is unclear why this fix was introduced and why no tests failed.

[areteichi]

Yes, I can verify this is happening to me as well. This error message repeatedly appears in the Nextcloud logs.

LockedException "Notes" is locked
Controller failed with OCP\Lock\LockedException

[maranov]

Can confirm, reverting a5bec1a does help, just in my case the shared-to user needed to temporarily set a different folder before I could re-share the original. Might be normal behavior caused by me deleting the share before, in an attempt to fix the issue.

Similar setup as OP, Notes 4.9.4.

[jaykijay]

Can confirm.. This is a regression for me :/

[lftsy]

Thanks for reporting it, got same problem, and did use the same revert of a5bec1a to fix it
I do share my "Notes" folder with my wife, and it was not working anymore, it was creating endlessly "Notes (2)", "Notes (3)", ... , up to "Notes (19)"
FYI, we are mainly using the "Nextcloud Notes" Android app where we had the problem using the "Steps To Reproduce" reported above

Best Regards

[Waltibaba]

All of my storage is external since my nextcloud docker container is ephemeral, so all storage is "shared" by group rules, even the user's home directory. So I can't use Notes any more.

The current implementation using Folder->getNonExistingName() couldn't have passed even superficial testing in a shared folder.
The program flow goes like this:
If the chosen notes folder exists but is shared, it may not be used and a new one is created (with an incrementing number appended).
Once it has been created, the existence check confirms that it exists, which now makes it forbidden since only non-existing folders are allowed, that's the point of getNonExistingName().
Therefore it fails to use the just created folder and a new (higher numbered) folder is created, and the cycle repeats forever.

So whenever NoteUtil->getOrCreateFolder is called (apparently quite frequently, on every note file save attempt), it creates a new empty copy of the forbidden existing folder. This goes on forever and creates hundreds of empty folders in minutes. Obviously, getNonExistingName is being used incorrectly.

Is there a reason for the apparent intention not to use existing shared folders?

[gerhardt]

Indeed, it's still broken, I've tried both options,
with and without the code

		if ($folder->isShared()) {
			$folderName = $this->root->getNonExistingName($path);
			$folder = $this->root->newFolder($folderName);
		}

it simply stays broken. I can't use the Notes app anymore together with my partner. At the legitimate user, who is sharing the folder, everything works fine. The one who is using the shared folder, gets these other folders 'Notes (2)' etc.