Slideshow photos for public links

[nextcloud]

Slideshow photos for public links

[menaceone]

Hey folks,
I really miss that feature as well. If any help for testing etc. is needed just ping me.
greetings

[ForgetMeOrNot]

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

[hroling]

This is really a big disappointment that the slideshow is not working in NC18 and the Photo app. I will skip NC18 and wait for NC19. I will downgrade to NC17 and restore my backup.

This is the first time i'm not glad with the new version since owncloud 5.

[Sandman0984]

Hi,
I would like to see this feature added to Photos as well! Just like @menaceone , I'll help with testing if you need it. Keep up the good work! Thank you!

[grenzverkehr]

This problem has nothing to do with "Photo" but with the fact that the "gallery slideshow" no longer exists (nextcloud/viewer#89 (comment)). If the problem is indeed only solved with the release of version 19, version 18 will remain useless for many people.

[jospoortvliet]

FYI, we are trying to fix this and other regressions asap. This was an oversight that even the testing during beta and rc didn't catch - sorry for that, lucky news is that you can get involved in testing to help avoid these issues next time!

See https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/32 for a more complete response.

[nursoda]

Folks…I think it would be sufficient to express feelings (support a claim by adding a thumbs-up) and to subscribe to the bug. I don't think 100 comments will speed up implementation. This still is a community effort. This speaking as non-dev, also waiting.

The NC dev mistake I see is that the app has been replaced by a newly developed one without proper notice to users that an important functionality is still missing AND without the option to use the old app for the time being.

[Aesculapius]

Same here, useless if without. How can such decision be made, as this clearly is a much used feature?

[jospoortvliet]

@hroling thank hard workers like @skjnldsv - he already fixed, I think, all of the problems! Deadline is soon, RC coming this week (Thursday, most likely). We'd all appreciate it if you and others were willing to help test that RC so we can get 18.0.2 as stable as possible!

[knrd1]

Hey,
I agree with the previous comments, in my humble opinion this was the most important Nextcloud's functionality. At this moment I can't share the gallery with anyone... Unless they agree to download each file...
Thanks!

[Englbrechtful]

Agreed, this is a very important functionality. Could the devs please comment on an ETA to fix this? Need to know if it makes sense to downgrade NC or if we can wait for a fix.
Thank you

[kev300]

Is there a chance that this important feature is also back ported to 18.0.2 or 3?
I don't want to wait until 19.. It really sucks that features are silently dropped without mentioning in the change log. :(

[szaimen]

FYI: #154 (comment)

[Chillstice]

18.0.4 finally came out today and I was excited to update and check out if this works again. Turns out, not really.

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I'm trying this with already existing shared-folders and I haven't tested extensively, but so far it doesn't appear to be working as intended.

[mwllgr]

Hi, same for me - please fix/add that feature again. Photo preview/slideshow in public links is a pretty useful feature for many users!

[skjnldsv]

Yes, sorry about this :)
Small delay in time, this have been merged and is part of the upcoming 18.0.3 release https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/40?u=skjnldsv

[skjnldsv]

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

[ainola]

Hm, I'm still getting downloads with 18.0.3 and a public share link. Should I be doing anything other than merely updating?

[BotoX]

First it's been 18.0.2, then 18.0.3 and now 18.0.4 which could take another month+
Can I just upgrade the photos plugin on my nextcloud install and skip yet another month of all my albums being down?

I really appreciate the work you guys put into this project, I've got a few smaller ones of my own and know how hard it can be to deal with lots of user inquiries in your free time.
But the way this has been handled so far is a really big turnoff for nextcloud.
At least present some kind of fix for affected people, since the code has seemingly already been written but not included in the release?
Thank you.

P.S. should this issue really be closed when it's not fixed in nextcloud yet?

[skjnldsv]

At least present some kind of fix for affected people, since the code has seemingly already been written but not included in the release?

Feel free to patch it yourself from the viewer/server code.
The pull requests have been linked in this issues and the associated ones.

But the way this has been handled so far is a really big turnoff for nextcloud.

We don't aim for weird patches and quick releases unless those touches security. Stability is the most important thing. If you want to skip the beta and rc tests phases to have your own instance up and running, feel free to do so. But This is a project that aims to be serious and professional and we cannot afford to risk things for the sake of having users not wait 1 month for a fix.

[Chillstice]

I just checked the console in a fresh chrome browser and I'm getting what appears to be a permission issue?
https://s.chillstice.com/ajHke

[fuco809]

we too used the "shared as link" gallery public view links, which are not implemented in photos yet. please bring back that feature.

[hroling]

FYI, we are trying to fix this and other regressions asap. This was an oversight that even the testing during beta and rc didn't catch - sorry for that, lucky news is that you can get involved in testing to help avoid these issues next time!

See https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/32 for a more complete response.

Thanks Jos. I really appreciate that.

[szaimen]

It will become available with 18.0.3

[quatze]

Same for me. This was one of the key features, when using nextcloud to share photos with family and friends. Would also love if anyone could point out how to downgrade to version 17.

[FanchTheSystem]

+1

Maybe nextcloud 18 should not have been in stable release channel...

[x42]

Is this being actively worked on?

[skjnldsv]

Let me try and see what is bugged :)
Thanks for testing!

[skjnldsv]

Whats the goal of having a separate app if development and release is bind to server release?

This is not a separate app, this is a separate repository.
This app is shipped with server releases :)

[hroling]

FYI: #154 (comment)

Thanks, it is working on my NC18 testserver

[Sandman0984]

FYI: #154 (comment)

This worked for me as well. Thank you! I'll still be looking for this feature in Photos as well, hopefully by NC19. Again, let me know if I can help with testing Photos in future releases.

[hroling]

Thanks. I will test it if the beta/rc's of NC 18.0.3 are ready.

[jhesketh]

Running today's daily build, the file no longer prompts to download but still won't display.

Firefox's console gives me the following:

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). 3 content-script.js:40:65
JQMIGRATE: Migrate is installed, version 1.4.1 jquery-migrate.min.js:2:551
This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. addStylesClient.js:220:17
Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20 2 globals.js:66:15
OCA.Viewer initialized Viewer.js:41:10
Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”). getInferredName.js:6:19
TypeError: "OCA.Text is undefined"
    data RichWorkspace.vue:75
    VueJS 6
        Me
        _data
        _n
        _n
        _init
        a
    render files.js:188
vue.esm.js:1897:12
    VueJS 8
        We
        Je
        Ve
        _data
        _n
        _n
        _init
        a
    render files.js:188
The humanFileSize library is deprecated! It will be removed in nextcloud 19. 2 globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. 5 globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. globals.js:66:15
The humanFileSize library is deprecated! It will be removed in nextcloud 19. 2 globals.js:66:15
Opening the viewer with a single string parameter is deprecated. Please use a destructuring object instead OCA.Viewer.open({ path: '/IMG_<REDACTED>.jpg' }) Viewer.js:97:11
Opening viewer for file  /IMG_<REDACTED>.jpg Viewer.vue:211
Error: "Request failed with status code 401"
    exports createError.js:16
    exports settle.js:17
    onreadystatechange xhr.js:61
Viewer.vue:383
    t Viewer.vue:383
    c runtime.js:45
    _invoke runtime.js:271
    t runtime.js:97
    H viewer.js:355
    a viewer.js:355

The 401 error is likely the problem. I can also see the response code from nextcloud server as 401. This could be a bug with the server, but I think the path for the full sized image is wrong.

The page does load, as do the thumbnails, it is just the full sized view that fails.

[jhesketh]

Yes, https://download.nextcloud.com/server/daily/latest.tar.bz2

[jhesketh]

I've ran occ files:cleanup with no obvious effect. I've tested viewing them in firefox private mode and chromium incognito (both new sessions) with the same result.

Thanks for helping debug. I'll share a test folder with you.

[hroling]

Latest version of 18.0 installed on my test server and works good.

[skjnldsv]

Thanks everyone for testing! It seems that all is well then!
Enjoy the incoming nc version! 🚀

Remember We love some more feedback on how you view the future of this app (search existing issues before 😉)! 🤗

[jhesketh]

Just a note for those following along, I was experiencing another bug due to my federation configuration: nextcloud/server#20132

[adsworth]

Hey,
is there any (roughly) estimated release date for 18.0.4 or is it "done when it's done"?

Apparently 23rd of April is the planned date.

https://github.com/nextcloud/server/milestone/115

[Leon5x]

A workaround until NC 18.0.4 is released is described here:
https://help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/20
You can enable the old gallery app under NC 18. But this app does only work on public shares without a password when you use the sharing link like before (url.com/apps/gallery/s/awhdkawhd).
Btw, thanks for fixing everything for the next release properly!

[NOTNlCE]

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I updated this morning and am NOT experiencing the above issue. Mine seems to work as intended, but I shared my albums fresh this morning.

[NOTNlCE]

I AM using External storage and have no issues.

[mwllgr]

@szaimen Nope, my files are stored locally and not encrypted on the server.

[benoitmasson]

Same for me with Firefox 75, in private browsing mode. I get a 401 error when trying to view an image (album listing and miniatures show correctly).

Exact error message in the HTTP response is:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
  <s:message/>
</d:error>

Requested URL is https://<myserver>/public.php/webdav/photo.jpg, so replying with a 401 is not surprising… the shared folder token does not appear in it.

[neufeind]

Same error here: NotAuthenticated ... 401
18.0.4 with local storage (but data-dir outside of the webroot), public link to a newly shared folder.
The folder opens, showing a list of files. But clicking on one gives that 401-error.

[skjnldsv]

Hello!
I'm not sure I understand, what do you mean by a preview popup? You mean opening the slideshow view on click?
Or you mean having the photo layout on 'public' pages?

[schaze]

Hi,
sorry for beeing unclear.
I do get thumbnails in the shared folder but not the slideshow view. If what you mean with slideshow view is this the one looking like this:

Instead I get this for the shared folder when accessing it via the share link:

[mikweb2017]

i have same problem

if I click on a photo it does not appear as a preview popup

[schaze]

@mikweb2017 : that is not the same problem as mine. My preview popup works in a normal photo page - I only have the issue when opening a photo in a shared folder (open via the share link).

[skjnldsv]

@mikweb2017 please open a separate issue :)

[skjnldsv]

Instead I get this for the shared folder when accessing it via the share link:

Ah, ok!
Yes, photos is not handling public links yet :)

[hezten]

Can anyone point me to a guide to downgrade to nextcloud 17 ? nextcloud 18 is useless for me without this feature

[menaceone]

I just upgraded my docker container to 18.0.2RC1-apache.
Unfortunately behaviour has not changed.
Still download dialog instead of Gallery view when clicking on a photo in a public link.

[nursoda]

…and 18.0.2RC1 is not offered as beta update (yet).

[skjnldsv]

Yep, not part of 18.0.2RC1 yet

[hroling]

NC test-server upgraded to 18.0.2 but unfortunately no solution yet. I will wait for next update.

[skjnldsv]

Running today's daily build, the file no longer prompts to download but still won't display.

Hey :)
What do you mean by today's build?

[nursoda]

Probably https://download.nextcloud.com/server/daily/ ?

[skjnldsv]

Just tested, works fine for me with the default archive you linked :)

[jhesketh]

Thanks so much for testing. Not sure what I am doing then that causes it not to work.

Here is the log for the file request:

app_1 | 172.30.0.2 - 5r8NP******AKzB [23/Mar/2020:09:31:22 +0000] "PROPFIND /public.php/webdav/IMG_2019****_21****.jpg HTTP/1.1" 401 1055 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0"

Does that URL look correct for an image inside a folder?

If you still have your test instance running, are you able to tell if there are any errors in your console log?

Thanks :-)

[skjnldsv]

I could reproduce your RichWorkspace error, and pinged the dev in charge.
But this is not related to this issue :)

Did you forbid the download of files in your share?
Maybe there is a permission error on the file?
Anything in your nextcloud.log?

[jhesketh]

I have the same issue with or without forbidding downloads. As well as via email shares and link shares. I have not confirmed user shares, but I /think/ they are working (but with read/write/all perms).

The image loads fine in the viewer for my user, so I don't think it's a filesystem permission.

I can't see anything in the nextcloud log either.

[skjnldsv]

Have you cleared your cache (just in case)
Are you opening the link share into your browser in private mode? Or are you logged in already?

Can you maybe send the link to [email protected]?

[skjnldsv]

It looks like you're still having the old viewer.
Could you share the info.xml file of the viewer app?

[jhesketh]

Oh, okay. I may have set it up incorrectly in docker then.

https://gist.github.com/jhesketh/b34fc3abce5fd488bc2512c1f9976f6c

The version in nextcloud settings is:
Nextcloud 18.0.2 Build:2020-03-13T23:01:51+00:00 17722835c0b0f2bbd62bf4fd09a167985f921202

I hadn't looked at this before. Is that the correct version for a daily build given the date is 10 days old?

[jhesketh]

Hmm, looking at the daily tar, it seems like I may not have installed it into the docker image correctly. This seems to be a problem on my end. Thank you very much for the help, I'll continue to debug my setup!

[skjnldsv]

Nextcloud 18.0.2 Build:2020-03-13T23:01:51+00:00 17722835c0b0f2bbd62bf4fd09a167985f921202

Like mentionned 😉

Yes, sorry about this :)
Small delay in time, this have been merged and is part of the upcoming 18.0.3 release help.nextcloud.com/t/new-photo-app-in-nextcloud-18/69949/40?u=skjnldsv

[hroling]

If I share a directory with photo's I don't see it in the shared albums. Is that correct?

[skjnldsv]

No, it's photos that are shared with you

[hroling]

No, it's photos that are shared with you

Thanks. That was nog really clear.... :)

[menaceone]

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

Hey,
is there any (roughly) estimated release date for 18.0.4 or is it "done when it's done"?

[skjnldsv]

P.S. should this issue really be closed when it's not fixed in nextcloud yet?

fixed and released are two different things :)

[hroling]

Is it possible to use the new app in NC 18.0.3? And, if yes, how?

[jean-io]

Yep, sorry, 18.0.3 is an unexpected security update.
18.0.4 it is :)

Why do you need to wait for a server upgrade if you can publish an new release of just the app?
Whats the goal of having a separate app if development and releases are bind to server?
🤔

Anyway thank for this great open source project 🥇

[mwllgr]

It works for me too. And I shared the album around three months ago.

[szaimen]

18.0.4 finally came out today and I was excited to update and check out if this works again. Turns out, not really.

The functionality appears to be returned - clicking an image from a gallery/ folder via shared link displays a lightbox - but the image never loads. It just indefinitely shows the loading animation.

I'm trying this with already existing shared-folders and I haven't tested extensively, but so far it doesn't appear to be working as intended.

I just checked the console in a fresh chrome browser and I'm getting what appears to be a permission issue?
https://s.chillstice.com/ajHke

I have the same problem. But it also doesn't work with new shares.

I am using external storage. Could that be the problem here?

[szaimen]

@NOTNlCE @mwllgr @Chillstice
Are you using external storage? That might be the problem here.

[Chillstice]

NVM ignore this, it was unrelated

I'm also seeing what might be a related error in the nextcloud log viewer:
Warning | l10n | Failed to load /var/www/cloud/public_html/apps/drop_account/l10n/en.json - json error code: 4

Oh, you know what, this is for an app that lets users delete their account, let me just disable that and retry.

[Chillstice]

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

omg that fixed it for me, but why??!?

Edit:

The problem is we can not tell the difference if it is a remote server grabbing the file or a user, so from my perspective it is a "will not fix" and instead the description needs adjusting.

[Atlantis1979]

See this bug:
#20132

You need to enable "Allow users on this server to send shares to other servers" in federation sharing, to get rid of 401 or infinite loading

After hours of research, this is the only thing that worked for me too. Thank you for saving me from madness.