Giter Site home page Giter Site logo

[RFC] Files mime icons theming about server HOT 4 OPEN

skjnldsv avatar skjnldsv commented on June 26, 2024
[RFC] Files mime icons theming

from server.

Comments (4)

susnux avatar susnux commented on June 26, 2024

I agree here, but additionally I would suggest to move to an inline-svg approach. Because currently it is not really possible to get the correct primary color.
The color depends on:

  • Theme the user uses
  • Preferred color schema of the browser

The first is "easy" to get on the backend, the second only with some new browser stuff not supported by e.g. Firefox.

So instead if we move to inline svgs instead of background images, we could simply use fill: var(--color-primary-element).

from server.

skjnldsv avatar skjnldsv commented on June 26, 2024

We would never use the primary color. I suggest removing this entirely in the first post :)

from server.

susnux avatar susnux commented on June 26, 2024

We would never use the primary color. I suggest removing this entirely in the first post :)

...

if folder, we always use the primary color

So we still have the primary for the folder, which suffers this issue on the PHP api

from server.

skjnldsv avatar skjnldsv commented on June 26, 2024

No the folder are inline svg right now, we migrated away from using the mime api :)
I'm talking about every other file type but a directory 📂

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.